Skip to content

Fixed formatting of output per issue #808 #1919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2017
Merged

Fixed formatting of output per issue #808 #1919

merged 1 commit into from
Dec 5, 2017

Conversation

sdwheeler
Copy link
Contributor

The examples were confusing because of the way the output was formatted. Fixed formatting to be clearer about the contents of the CSV files.

See issue #808 for more info.

Version(s) of document impacted

  • Impacts 6 document
  • Impacts 5.1 document
  • Impacts 5.0 document
  • Impacts 4.0 document
  • Impacts 3.0 document

Sorry, something went wrong.

@sdwheeler sdwheeler requested a review from zjalexander December 4, 2017 18:46
@markekraus
Copy link
Contributor

If I remember correctly, PlatyPS was failing when you have 2 code blocks in an example section (#1795). that is why they are in one block as a comment.

@saldana
Copy link
Contributor

saldana commented Dec 4, 2017

✅ Validation status: passed

File Status Preview URL Details
reference/3.0/Microsoft.PowerShell.Utility/Export-Csv.md ✅Succeeded
reference/4.0/Microsoft.PowerShell.Utility/Export-Csv.md ✅Succeeded
reference/5.0/Microsoft.PowerShell.Utility/Export-Csv.md ✅Succeeded
reference/5.1/Microsoft.PowerShell.Utility/Export-Csv.md ✅Succeeded
reference/6/Microsoft.PowerShell.Utility/Export-Csv.md ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@sdwheeler
Copy link
Contributor Author

@markekraus It appears that Platyps has no problem with this now. See the attached file.
Microsoft.PowerShell.Commands.Utility.dll-Help.xml.zip

@markekraus
Copy link
Contributor

@sdwheeler awesome news! I see the language spec for the block is Output, perhaps lacking that is what caused the issue. Anyway, good to know!

@sdwheeler
Copy link
Contributor Author

sdwheeler commented Dec 4, 2017

@markekraus the Output "language" is not officially supported. However, OPS will use that to label the code box on the rendered webpage. It treats the code block as plain text with no highlighting. So it makes it clearer to the reader that we are dealing with output.

@zjalexander zjalexander merged commit bbe8f07 into MicrosoftDocs:staging Dec 5, 2017
@sdwheeler sdwheeler deleted the sdw-issue808 branch December 7, 2017 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants