Skip to content

Conversation

rafaelvzago
Copy link

Summary

  • Add 11 contemporary color scheme skins including popular themes like Catppuccin, Gruvbox, Nord, Tokyo Night, and others
  • Update Makefile.am to include new skin files in distribution
  • Provide modern color options for MC users who prefer contemporary terminal themes

Test plan

  • Verify all skins load correctly with mc -S <skin-name>
  • Test color rendering in different terminal environments
  • Confirm Makefile.am includes all new skin files for proper distribution
  • Validate skin syntax and color definitions

New skins added

  • catppuccin.ini (mocha variant)
  • catppuccin-latte.ini (light variant)
  • everforest.ini
  • gruvbox.ini
  • kanagawa.ini
  • matte-black.ini
  • nord.ini
  • osaka-jade.ini
  • ristretto.ini
  • rose-pine.ini
  • tokyo-night.ini

@github-actions github-actions bot added needs triage Needs triage by maintainers prio: medium Has the potential to affect progress labels Oct 1, 2025
@github-actions github-actions bot added this to the Future Releases milestone Oct 1, 2025
@mc-worker
Copy link
Contributor

Please remove *.po files from your commit. po-files are updated from Transifex.

Add contemporary color schemes including Catppuccin (latte/mocha),
Everforest, Gruvbox, Kanagawa, Nord, Rose Pine, Tokyo Night, and
others. Update Makefile.am to include new skin files in distribution.

Signed-off-by: Rafael Zago <[email protected]>
@rafaelvzago
Copy link
Author

Thanks for you review. Changes made under: 83c0e96

@zyv zyv added area: skin Theming support and skin files and removed needs triage Needs triage by maintainers labels Oct 6, 2025
Copy link
Member

@zyv zyv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thank you for the contribution! Cheers to Jindrich N. if you happen to work with him :)

I haven't tried these skins live, but I have checked them quickly for non-contrast colors with our new skin browser:

https://skins.midnight-commander.org

I would otherwise complain about the colors, because my understanding is that these are color schemes that are used like that in other software and people like them, so they should be taken as is. But invisible text somehow I think it better be addressed.

I think most skins are unproblematic, but I have found two exceptions. Could you please find a tweak that works?

catppuccin-latte

Image

catppuccin

Image

Also, a general question: you have added a test plan in the PR. Did you actually perform it?

[widget-editor]
window-state-char = *
window-close-char = X No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that all the files are missing a trailing newline, whereas all our skins consistently have it. We don't have a linter for this, but I would appreciate it if you could fix it for consistency.

skindir = $(pkgdatadir)/skins

skin_DATA = \
catppuccin.ini \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By convention, all our 256-color skins are named something256.ini to make it possible to have fallback non-256 versions and possibly boosted 16M versions of the same general scheme.

I think it would make sense to stick to this convention, and I would appreciate you renaming the files.

removed = color238;color210
error = color210;color248

[widget-panel]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Historically, it is so that our 256+ color skins use "fancy" characters for rendering (see, e.g. yadt256.ini for an example of a "thin" skin - that is one not using the double lines) instead of normal terminal characters because it is assumed that if the terminal can display 256 colors, it also must be able to display UTF-8.

I think it would make sense to stick to this pattern for these color schemes unless you want to design something special for them.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: skin Theming support and skin files prio: medium Has the potential to affect progress
Development

Successfully merging this pull request may close these issues.

3 participants