Skip to content

Highlight.js does not support JSON comments #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ChampionAsh5357 opened this issue Apr 3, 2022 · 1 comment
Closed

Highlight.js does not support JSON comments #430

ChampionAsh5357 opened this issue Apr 3, 2022 · 1 comment
Labels
Theme Related to the theme of the docs

Comments

@ChampionAsh5357
Copy link
Contributor

Although GitHub codeblocks support to use of different JSON configurations (json5, jsonc), Highlight.js does not support commented json. Instead, it actively resolves the script between either coffeescript (causing the highlighting errors) and php (which surprisingly works without any issue).

To support JSON with comments, it was recommended to use the JS highlighter or to create our own distribution of highlight.js.
@ChampionAsh5357 ChampionAsh5357 added the Theme Related to the theme of the docs label Apr 3, 2022
@ChampionAsh5357 ChampionAsh5357 mentioned this issue Apr 10, 2022
Merged
@sciwhiz12
Copy link
Contributor

Addressed by #433.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Theme Related to the theme of the docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChampionAsh5357 @sciwhiz12