Add support for commented json #425
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Like I said when on #406, there isn't a reason to have JSON highlight comments. It's probably better to just use the javascript highlighter and not have a separate language definition for such a small difference. |
|
Ok. Good point about using the javascript highlighter. |
|
@UnquietCode Have you considered forking |
|
I hadn't heard of the JSON5 spec yet but I like the design still being
JavaScript compatible. Sounds like a fun weekend project! :)
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how useful this is for others, but some JSON parsing frameworks support non-standard C-style comments. It was pretty easy to mix in the comment types so I created a
json-commentslanguage (updating thejsonlanguage was inappropriate since these are non-standard).Please feel free to merge or close. Thanks for the great tool!