-
Notifications
You must be signed in to change notification settings - Fork 185
Conversation
* [Production workflows](docs/production-workflows.md) | ||
* [Circular References & Bindings](docs/circular-references-bindings.md) | ||
* [Extending the loader through loader hooks](docs/loader-extensions.md) | ||
* [Tracing API](docs/tracing-api.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These links do need to be at the top. Perhaps make the first one an anchor link within the README if that's what you're after?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These links just repeat what's in the previous section (in a more concise form), and it seemed to me that people coming to this file would want to read the getting started section first, and only then maybe want to move on to more details. So put the documentation links at the end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The links at the top might be missed, with users wondering where the docs are - nice to make it easy to find on the page.
Thanks, note that because this repo provides no production workflow, it is not suitable for end-users and is more appropriate for implementors at this point. So the documentation is moving to reflecting that as well somewhat, hence why the basic ES6 module info was removed. |
if you're moving general usage docs to systemjs, it might be better to have the note on Promise.all in there (somewhere) |
In general, it is advisable to have a single main entry point over multiple import promises, so it's not something I'd want to encourage too heavily. |
Thanks again for the suggestions - it's great to have this documentation feedback. |
I'm using it for optional loads: parse querystring into an array and load the requested components with Promise.all. I don't think it makes sense in a static situation. |
Proposes:
Question: why is https://github.com/systemjs/systemjs/blob/master/docs/es6-modules-overview.md in systemjs? This surely belongs here.