Github-toggle-expanders: handle PR comments #21
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have chosen to handle the click only for the current review, not all reviews done in the PR wich could be too much (and less interesting from my use case -> check everything is OK for one review) So the selector is `..discussion-item-body` and not `.js-discussion`
Well, definetely not working, please do not merge while I fix that ;-) |
|
Hi @cmalard! Hehe no worries. So you're saying Shift+click should only be toggling the expanders for the file you're reviewing? |
|
Hi @Mottie , I'm talking about toggling for only 1 review: |
|
Oh! This userscript is targeting the ellipsis expanders seen on commits with descriptions longer than a certain amount. Like on this page. I'm okay with this userscript also toggling the outdated blocks for a single review. Are you still working on it? |
|
Well, it seems I have to open a new PR :-D
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have chosen to handle the click only for the current review,
not all reviews done in the PR wich could be too much
(and less interesting from my use case -> check everything is OK for one review)
So the selector is
.discussion-item-bodyand not.js-discussionI had to refactor to match the closest parent.
As a consequence, there is no longer the need to support
#commits_bucketto fix #8