Skip to content

Gevent Monkey Patching issue with Requests #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MJJoyce opened this issue Mar 25, 2020 · 1 comment
Open

Gevent Monkey Patching issue with Requests #253

MJJoyce opened this issue Mar 25, 2020 · 1 comment
Assignees

Comments

@MJJoyce
Copy link
Member

MJJoyce commented Mar 25, 2020

In certain import or execution scenarios we can end up monkey patching ssl after it has already been imported. This can cause known issues in Python >= 3.6.

gevent/gevent#1016

The GUI docs build seems to be running into this issue because the leapseconds.dat file needs fetch (which makes a request call). I can replicate this by deleting my local leapseconds.dat file and attempting to build the GUI docs.

We should move the monkey patch calls in Core and the other repos to address this.

@MJJoyce MJJoyce self-assigned this Mar 25, 2020
@MJJoyce
Copy link
Member Author

MJJoyce commented Mar 25, 2020

I think putting the monkey patch call at the beginning of ait.core.__init__ and ensuring that our child repos import ait.core first (probably in the ait.<repo>.__init__ file would address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant