Issue #156 - Update RTD Python version and fix doc build issues #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MJJoyce
commented
Mar 25, 2020
MJJoyce
commented
- Update Python version in RTD config
- Bump Sphinx version in GUI to match Core
- Fix gevent monkey patch timing issue (See Gevent Monkey Patching issue with Requests AIT-Core#253 for additional info) by patching in GUI first thing in Sphinx conf.py. This might not be the final solution to this but it resolves issues for now.
Update the Python version in RTD config Monkey patch gevent in the sphinx conf.py file to ensure that monkey patching is done prior to any other imports. This is to avoid a known issue where SSL is imported prior to patching and an infinite recursion problem is encountered. See AIT-Core/issues/253 Bump GUI Sphinx version to match Core
|
RTD build is looking good with this PR after these changes 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.