Allow disabling repos per default #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le-collection-elasticstack into feature/specificversion-98
Closed
|
Looks like it's like I was fearing when I started this PR. We'll need different tasks for rpm and deb based installations. This lets the counts of installation tasks explode because we already have to take care of several special situations. Maybe we can come up with a simpler solution. |
Looks like when running on Debian, you can't add options to `package` that won't work with `apt`, even when this task is skipped.
|
Needs #113 to be merged before all checks can work |
afeefghannam89
approved these changes
Mar 13, 2023
ivareri
pushed a commit
to ivareri/ansible-collection-elasticstack
that referenced
this pull request
Jun 17, 2025
This introduces a new variable that will disable yum repositories per default and re-enables them temporarily when modifying packages. It's not possible to disable apt repositories temporarily so we need to have two different approaches. fixes NETWAYS#106 fixes NETWAYS#76 fixes NETWAYS#98 supersedes NETWAYS#101
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new variable that will disable yum repositories per default and re-enables them temporarily when modifying packages. It's not possible to disable apt repositories temporarily so we need to have two different approaches.
fixes #106
fixes #76
fixes #98
supersedes #101