Skip to content

Fix #40 #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Fix #40 #46

merged 2 commits into from
Feb 10, 2023

Conversation

afeefghannam89
Copy link
Member

@afeefghannam89 afeefghannam89 commented Feb 7, 2023

This fix will let Logstash be able to read the certificate key file.

Fix #40

Copy link
Member

@martialblog martialblog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, I would change the Commit message to be more descriptive

@widhalmt
Copy link
Member

widhalmt commented Feb 8, 2023

We tested an abundance of combinations of Logstash, Beats-Plugin and JREs and all we could verify is that "it depends". Some work, others don't but we couldn't find a pattern that will reliably work. So guess, the next steps are to deactivate encryption of certificates and add an issue to retest in a few verions.

because it is not reliable
Copy link
Member

@widhalmt widhalmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the failed test only happened due to a timeout. Hereby I approve.

@afeefghannam89 afeefghannam89 merged commit ada3cfe into main Feb 10, 2023
@afeefghannam89 afeefghannam89 deleted the fix/tls_certificates branch February 10, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix TLS certificates for Beats connection
3 participants