fix: GetStreamsToSnapshot crashing for results with more than 512 items

[brustolin]

The previous code were trying to set the @StreamId variable that is not available in the query.
The @Limit @Skip variable is set inside the PagedEnumerationCollection iterator, so there is no need for a NextPageDelegate callback in here.

Fixes #54

[Copilot]

Pull Request Overview

This PR fixes a crash in GetStreamsToSnapshot when handling result sets with more than 512 items by removing an invalid parameter assignment that referenced a non-existent @StreamId variable in the SQL query.

• Removes the callback that was attempting to set an invalid @StreamId parameter
• Simplifies the paged query execution by using an empty callback since the @Limit parameter is handled automatically

[Copilot]

[nitpick] The comment should be more descriptive about why no next page delegate is needed. Consider: '// No next page delegate needed - @limit parameter is handled automatically by PagedEnumerationCollection'

Suggested change

	(q, s) => { }) // There is no need for next page delegate in the Snapshot stream
	(q, s) => { }) // No next page delegate needed - @Limit parameter is handled automatically by PagedEnumerationCollection

[AGiorgetti]

@copilot Can you double check if: "No next page delegate needed - @limit parameter is handled automatically by PagedEnumerationCollection" is true?

[brustolin]

@AGiorgetti, sorry, my PR descriptions was wrong, its the @Skip variable that is handled by the PagedEnumerationCollection, but the behavior stills the same.

As you can see in the following code, the limit variable is set than _nextPage (the delegate) is called.

NEventStore.Persistence.SQL/src/NEventStore.Persistence.Sql/SqlDialects/PagedEnumerationCollection.cs

Lines 148 to 158 in 437636b

	private bool MoveToNextRecord()
	{
	if (_pageSize > 0 && _position >= _pageSize)
	{
	_command.SetParameter(_dialect.Skip, _position);
	if (_current is null)
	{
	throw new InvalidOperationException("Enumeration not started.");
	}
	_nextPage(_command, _current);
	}

[AGiorgetti]

hi @brustolin , I was testing copilot review ability :) Is it possible to also add a test case in order to avoid future regression? Thanks.

[brustolin]

@AGiorgetti I can try to add the tests, but I'm quite busy for a while, so it may take some time.