Skip to content
This repository was archived by the owner on Aug 12, 2020. It is now read-only.

Commit 0352497

Browse files
committed
Disabled no-any and no-reserved-keywords tslint rule.
Refs #20
1 parent 69814e1 commit 0352497

File tree

4 files changed

+6
-2
lines changed

4 files changed

+6
-2
lines changed

packages/react-scripts/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"react-scripts": "./bin/react-scripts.js"
2424
},
2525
"dependencies": {
26-
"@nlesc/tslint-config-react-app": "^1.0.0",
26+
"@nlesc/tslint-config-react-app": "^1.0.1",
2727
"@types/jest": "^15.1.32",
2828
"autoprefixer": "6.5.1",
2929
"awesome-typescript-loader": "^2.2.4",

packages/tslint-config-react-app/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,10 @@ To use in `create-react-app` we overridden several rules to make it compatible w
1818
* jsx-self-close, want linting on jsx
1919
* member-access, everything that has no access modifier is public implicitly, so no need to specify public again
2020
* missing-jsdoc, not useful for an application, it would be for a library
21+
* no-any, not everything has to be to typed to allow for incrementally introduction of types for eg. 3rd party libraries
2122
* no-relative-imports, not practical for an application, it would be for a library because it has a package name
2223
* no-for-in-array, tslint in create-react-app does not do typecheck
24+
* no-reserved-keywords, redux requires `type` keyword for a action, the rule doesn't allow us to whitelist `type` so we disabled whole rule
2325
* no-unused-variable:[true, "react"], allow React to be marked used by jsx tags
2426
* restrict-plus-operands, tslint in create-react-app does not do typecheck
2527
* quotemark

packages/tslint-config-react-app/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@nlesc/tslint-config-react-app",
3-
"version": "1.0.0",
3+
"version": "1.0.1",
44
"description": "TSLint configuration used by Create React App",
55
"main": "tslint.json",
66
"scripts": {

packages/tslint-config-react-app/tslint.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,10 @@
1313
"jsx-self-close": true,
1414
"member-access": false,
1515
"missing-jsdoc": false,
16+
"no-any": false,
1617
"no-relative-imports": false,
1718
"no-for-in-array": false,
19+
"no-reserved-keywords": false,
1820
"no-unused-variable": [true, "react"],
1921
"restrict-plus-operands": false,
2022
"quotemark": [

0 commit comments

Comments
 (0)