Skip to content
This repository was archived by the owner on Aug 12, 2020. It is now read-only.

add tslint config and command #20

Closed
jspaaks opened this issue Nov 3, 2016 · 3 comments
Closed

add tslint config and command #20

jspaaks opened this issue Nov 3, 2016 · 3 comments

Comments

@jspaaks
Copy link

jspaaks commented Nov 3, 2016 •
edited
Loading

@jspaaks jspaaks changed the title add tslint config and command add tslint and csslint config and command Nov 3, 2016
@sverhoeven sverhoeven self-assigned this Nov 4, 2016
sverhoeven added a commit that referenced this issue Nov 4, 2016
@sverhoeven
Added tslint for editor and webpack
f7a779a 
Refs #20
@sverhoeven
Copy link
Member

Took tslint.json from molviewer and adjusted rules to so example code passes.

@sverhoeven
Copy link
Member

sverhoeven commented Nov 4, 2016 •
edited
Loading

Atm tslint shows warnings during npm start, but does not terminate. npm run build does not show warnings and does not terminate.

@sverhoeven sverhoeven removed their assignment Nov 4, 2016
@jspaaks
Copy link
Author

jspaaks commented Nov 7, 2016

  • add microsoft tslint rules
  • add
https://github.com/Microsoft/tslint-microsoft-contrib
"react-no-dangerous-html": true,
"react-this-binding-issue": true,
"react-unused-props-and-state": true,
"react-anchor-blank-noopener": true,
"react-tsx-curly-spacing": [true, "never", {"allowMultiline": false}]]

https://github.com/palantir/tslint-react
"jsx-alignment": true,
"jsx-curly-spacing": already covered by tslint-microsoft-contrib/react-tsx-curly-spacing
"jsx-no-lambda": true,
"jsx-no-multiline-js: already covered by tslint-microsoft-contrib/react-tsx-curly-spacing
"jsx-no-string-ref": true,
"jsx-self-close": true

jspaaks added a commit that referenced this issue Nov 7, 2016
@jspaaks
added tsconfig compiler options; fixes issue #20
a4bf832
sverhoeven added a commit that referenced this issue Nov 7, 2016
@sverhoeven
* Exclude React from unused vars
86fc22a 
* Made example source code compliant with linters
* Renamed tslint package to be inline with eslint package
* Add more meta data to tslint-config-react-app package

Refs #20
@sverhoeven sverhoeven changed the title add tslint and csslint config and command add tslint config and command Nov 7, 2016
sverhoeven added a commit that referenced this issue Nov 9, 2016
@sverhoeven
Disabled no-any and no-reserved-keywords tslint rule.
0352497 
Refs #20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sverhoeven @jspaaks