Add support for bool type for the numba operator #5666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
|
CI MESSAGE: [19138731]: BUILD STARTED |
|
CI MESSAGE: [19138731]: BUILD FAILED |
- adds support for bool types inside the numba operator - adds a test for that for CPU and GPU Signed-off-by: Janusz Lisiecki <[email protected]>
JanuszL
force-pushed
the
add_bool_numba
branch
from
8d72fef to
99f2802
Compare
|
!build |
|
CI MESSAGE: [19139148]: BUILD STARTED |
banasraf
approved these changes
Oct 8, 2024
|
CI MESSAGE: [19139148]: BUILD PASSED |
mzient
reviewed
Oct 9, 2024
Comment on lines
53
to
56
| for z in range(tz, out0.shape[0], z_s): | ||
| for y in range(ty, out0.shape[1], y_s): | ||
| for x in range(tx, out0.shape[2], x_s): | ||
| out0[z][y][x] = 1 |
There was a problem hiding this comment.
Is it how it's done in numba, or can/should we use a more pythonic/numpyic way?
Suggested change
| for z in range(tz, out0.shape[0], z_s): | |
| for y in range(ty, out0.shape[1], y_s): | |
| for x in range(tx, out0.shape[2], x_s): | |
| out0[z][y][x] = 1 | |
| out0[tz::z_s, ty::y_s, tx::x_s] = 1 |
Signed-off-by: Janusz Lisiecki <[email protected]>
JanuszL
force-pushed
the
add_bool_numba
branch
from
c357ad7 to
7242078
Compare
|
!build |
|
CI MESSAGE: [19173232]: BUILD STARTED |
mzient
approved these changes
Oct 9, 2024
|
CI MESSAGE: [19173232]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
New feature (non-breaking change which adds functionality)
Description:
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A