Skip to content

Conversation

mzient
Copy link
Contributor

@mzient mzient commented Jan 31, 2025

Category:

New feature (non-breaking change which adds functionality)

This PR adds error translation to the C API 2.0.

Description:

The errors are caught in a macro and translated to a status code and a message stored in TLS.

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@mzient mzient force-pushed the C_API2_error_handling branch 3 times, most recently from 6e3bd01 to 14aebea Compare February 13, 2025 11:57
Signed-off-by: Michał Zientkiewicz <[email protected]>
@mzient mzient force-pushed the C_API2_error_handling branch from 14aebea to 813dba7 Compare February 18, 2025 10:30
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24121150]: BUILD STARTED

Signed-off-by: Michal Zientkiewicz <[email protected]>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24127410]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24140989]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24127410]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24140989]: BUILD FAILED

@mzient mzient merged commit e27559d into NVIDIA:main Feb 19, 2025
5 of 6 checks passed
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24140989]: BUILD PASSED

5had3z pushed a commit to 5had3z/DALI that referenced this pull request Feb 23, 2025
* C API error handling.
* C API initialization
* Workaround cross-DLL issues when comparing `std::error_category`

---------

Signed-off-by: Michal Zientkiewicz <[email protected]>
5had3z pushed a commit to 5had3z/DALI that referenced this pull request Feb 23, 2025
* C API error handling.
* C API initialization
* Workaround cross-DLL issues when comparing `std::error_category`

---------

Signed-off-by: Michal Zientkiewicz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants