Coverity check 04.2025 #5912
Merged
Coverity check 04.2025 #5912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Szymon Karpiński <[email protected]>
Signed-off-by: Szymon Karpiński <[email protected]>
Signed-off-by: Szymon Karpiński <[email protected]>
mzient
reviewed
May 6, 2025
| @@ -161,7 +161,7 @@ class binning_resource : public binning_resource_base<Kind, nstatic_bins, Interf | |||
| binning_resource(const SplitPointCollection &split_points, | |||
| const ResourceCollection &resources, | |||
| Extra &&extra) | |||
| : base(split_points, resources), extra_args_(std::forward<ExtraArgs>(extra)) { | |||
| : base(split_points, resources), extra_args_(std::forward<Extra>(extra)) { | |||
There was a problem hiding this comment.
Weren't there more of those?
There was a problem hiding this comment.
The other instances of use-after-move warnings turned out to be in the tests where we specifically test moving objects
mzient
approved these changes
May 6, 2025
awolant
approved these changes
May 8, 2025
|
!build |
|
CI MESSAGE: [28137489]: BUILD STARTED |
|
CI MESSAGE: [28137489]: BUILD PASSED |
mdabek-nvidia
pushed a commit
to mdabek-nvidia/DALI
that referenced
this pull request
Jun 7, 2025
* Add missing CUDA error check * Replace ExtraArgs with Extra in std::forward * Fix std::forward in disjoint_set Signed-off-by: Szymon Karpiński <[email protected]> Signed-off-by: Marek Dabek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Bug fix (non-breaking change which fixes an issue)
Description:
This MR fixes the issues found in the recent coverity check
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A
DALI-4242