-
Notifications
You must be signed in to change notification settings - Fork 520
docs: Add release notes #1141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add release notes #1141
Conversation
Documentation preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Mike. This should also link to the github CHANGELOG.md that sits at the top level of the repo. And @Pouyanpi, @tgasser-nv, when we update that changelog on a release we should link to this release-notes.md.
@mikemckiernan It was not supported but we could call it a bug git checkout v0.13.0 then from nemoguardrails import RailsConfig, LLMRails
config = RailsConfig.from_path("./examples/configs/gs_content_safety/config")
rails = LLMRails(config, verbose=False)
# it is not set in config
assert config.models[0].model is None
assert not hasattr(config.models[0], "model_name")
rails = LLMRails(config, verbose=False)
# meta/llma-3.3-70b-instruct is define in the config with model_name
# but it is not used as main llm
assert rails.llm.model != "meta/llama-3.3-70b-instruct"
# actually, it is using the default provided by ChatNVIDIA()
assert rails.llm.model == "meta/llama3-8b-instruct"
# it works because it is using the default provided by ChatNVIDIA
rails.generate(messages=[{"role": "user", "content": "what can you do?"}]) |
8d553cd
to
1c0fda0
Compare
Thanks for the help with this Pouyan. I can't wait for Tim to get started on refactoring some config work. This is not the kind of surprise that I like. I moved the changes to the GS pages to PR #1146 to keep the changes a little more manageable. |
@mikemckiernan let's comeback to it once I updated the changelog.md, there are more changes and having the CHNAGELOG will make this task easier. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1141 +/- ##
========================================
Coverage 68.65% 68.65%
========================================
Files 161 161
Lines 15978 15978
========================================
Hits 10969 10969
Misses 5009 5009
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
33c09e6
to
ff1eca0
Compare
Signed-off-by: Mike McKiernan <[email protected]>
ff1eca0
to
4138720
Compare
Signed-off-by: Mike McKiernan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks great 👍🏻
Description
Add release notes so that recent additions to this large set of HTML pages are more findable.
Related Issue(s)
Checklist