Potential fix for #180 #181
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 1, 2023 03:25
for unclear reasons opt_batch will later divided by 2 anyways.
For some reason it was replaced with text_optlen at some point and the actual minlength value was never used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#180
Potentially fixes the problem where a token optimal length over the minimal value fails when the engine also triggers the onnx export.
I just adjusted the
get_batch_dimso, when called with the default engine generation parameters, with the only difference being the optimal and maximal token length being increased, it produces the default engine but with optimal and max token length raised.And I pass the token_min_length parameter from the ui that was abandoned through the objects so the token_min_length can actually be set. Right now min_length and opt_length are just the same value (opt_length).