fix: don't perform memory estimation for star_attention #3485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/bot run --disable-fail-fast |
yuxianq
approved these changes
Apr 11, 2025
|
PR_Github #1936 [ run ] triggered by Bot |
|
@HuiGao-NV Please unwaive the tests in #3464. |
|
/bot kill |
|
PR_Github #1942 [ kill ] triggered by Bot |
|
PR_Github #1936 [ run ] completed with state |
|
PR_Github #1942 [ kill ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #1945 [ run ] triggered by Bot |
|
PR_Github #1945 [ run ] completed with state |
Signed-off-by: Hui Gao <[email protected]>
Signed-off-by: Hui Gao <[email protected]>
HuiGao-NV
force-pushed
the
skip_mem_est_for_star_attention
branch
from
04c56ce to
2f81f37
Compare
juney-nvidia
changed the title
|
/bot reuse-pipeline |
|
PR_Github #1989 [ reuse-pipeline ] triggered by Bot |
|
PR_Github #1989 [ reuse-pipeline ] completed with state |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mem estimation for star attention is not supportted now. So need to skip memory estimation for start_attention.