Skip to content

Conversation

amitz-nv
Copy link
Collaborator

@amitz-nv amitz-nv commented Jun 10, 2025

Description

Make LoRA pytorch to broadcast weights & config tensors only on new LoRA adapter, so when the adapter is already loaded on rank 0 (and thus, should be loaded on other ranks as well), only the adapter ID is sent in the request.

NOTE: The changes in this PR cause requests with a LoRA adapter that were previously unloaded from LoRA CPU cache not to work, as they remain in _cpp_lora_weights in LoraManager python class. It was decided that for now this flow is not supported, in favor of its significant performance boost.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@amitz-nv
Copy link
Collaborator Author

/bot run --stage-list "DGX_H100-4_GPUs-PyTorch-Others-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8251 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8251 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5977 (Partly Tested) completed with status: 'FAILURE'

@amitz-nv amitz-nv changed the title Fix LoRA broadcast issue in pytorch flow Fix LoRA pytorch to broadcast weights & config tensors only on new LoRA adapter Jun 19, 2025
@amitz-nv amitz-nv force-pushed the dev-fix-lora-torch-broadcast branch from 2be6ca3 to c16bf53 Compare June 19, 2025 11:08
@amitz-nv
Copy link
Collaborator Author

/bot run

@amitz-nv amitz-nv changed the title Fix LoRA pytorch to broadcast weights & config tensors only on new LoRA adapter [TRTLLM-5921][feat] Prevent serialization of entire LoRA adapters in each request Jun 19, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #9501 [ run ] triggered by Bot

@amitz-nv amitz-nv requested a review from shaharmor98 June 19, 2025 11:15
@amitz-nv amitz-nv requested a review from shaharmor98 June 19, 2025 11:22
@amitz-nv amitz-nv force-pushed the dev-fix-lora-torch-broadcast branch from b458fb1 to 9d5476e Compare June 19, 2025 13:58
@amitz-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9518 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9501 [ run ] completed with state ABORTED

@shaharmor98
Copy link
Collaborator

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9522 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9518 [ run ] completed with state ABORTED

@amitz-nv amitz-nv marked this pull request as ready for review June 19, 2025 14:45
@amitz-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9529 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9522 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9529 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6992 completed with status: 'FAILURE'

Copy link
Collaborator

@shaharmor98 shaharmor98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small last comment.
LGTM

@shaharmor98
Copy link
Collaborator

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9635 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9635 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #7082 completed with status: 'FAILURE'

@amitz-nv amitz-nv force-pushed the dev-fix-lora-torch-broadcast branch from 9d5476e to f651c79 Compare June 24, 2025 07:28
@amitz-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9654 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9654 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #7097 completed with status: 'FAILURE'

@amitz-nv amitz-nv force-pushed the dev-fix-lora-torch-broadcast branch from f651c79 to a13fb4a Compare June 24, 2025 10:44
@amitz-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9697 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9697 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #7132 completed with status: 'FAILURE'

@amitz-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9710 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9710 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #7145 completed with status: 'FAILURE'

@shaharmor98
Copy link
Collaborator

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9818 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9818 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #7244 completed with status: 'FAILURE'

@amitz-nv amitz-nv force-pushed the dev-fix-lora-torch-broadcast branch from 03e0751 to eb2fd3c Compare June 25, 2025 11:30
@amitz-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9874 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9874 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #7286 completed with status: 'SUCCESS'

@shaharmor98 shaharmor98 merged commit e0bb123 into NVIDIA:main Jun 26, 2025
3 checks passed
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 9, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 10, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 11, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 11, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants