Skip to content

Conversation

zhengd-nv
Copy link
Collaborator

@zhengd-nv zhengd-nv commented Jun 10, 2025

Description

Only use necessary number of processes when prefetching.

This is probably the root cause of the flaky nvbug/5301492, because 4 ranks are used in the test and the prefetching used up to 8xCPU core / 64 processes, while only 4 is needed because the model is small. Some ranks may end up with the following message and stop logging after the Prefetching 2.05GB checkpoint files. log, without a corresponding Loading {file}:

[2025-06-10T02:31:05.687Z]   File "/usr/local/lib/python3.12/dist-packages/tensorrt_llm/commands/serve.py", line 68, in _signal_handler_cleanup_child
[2025-06-10T02:31:05.687Z]     sys.exit(128 + signum)
[2025-06-10T02:31:05.687Z] SystemExit: 143

Other ranks will waiting for the defunct rank and finally lead to timeout/broken pipe.

The affected tests are:

  • test_disaggregated_load_balance (pipeline 12885)
  • test_disaggregated_cache_aware_balance (pipeline 12908, 12909)
    • test_workers_kv_cache_aware_router
  • test_disaggregated_conditional (pipeline 12894)

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@zhengd-nv zhengd-nv requested a review from a team as a code owner June 10, 2025 10:47
@zhengd-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8283 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8283 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5996 completed with status: 'FAILURE'

@zhengd-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8361 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8361 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6055 completed with status: 'FAILURE'

@zhengd-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8405 [ run ] triggered by Bot

@zhengd-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8405 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6091 completed with status: 'FAILURE'

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8460 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8460 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6129 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@zhengd-nv zhengd-nv requested a review from yuxianq June 12, 2025 02:12
@Shixiaowei02 Shixiaowei02 merged commit c592798 into NVIDIA:main Jun 12, 2025
3 checks passed
@zhengd-nv zhengd-nv deleted the limit-process-pool branch June 12, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants