Skip to content

Conversation

2ez4bz
Copy link
Collaborator

@2ez4bz 2ez4bz commented Jun 12, 2025

linting(python): Enable ruff on more files (wave 1/N)

Description

  • Why?

ruff check and ruff format are standard linting and formatting tools used in python projects. Prior to this commit, they were only enabled for a very minor subset of the repo.

  • What?

This commit is the first in a series to add more files in the include list. The order is roughly from least to most frequently updated files / directories.

It also removes the isort and autoflake hooks, since ruff covers both of those.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@2ez4bz 2ez4bz force-pushed the dev-ruff branch 3 times, most recently from 34467ea to 1c66b7b Compare June 12, 2025 18:12
Copy link
Member

@lucaslie lucaslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you for taking on this effort

@lucaslie
Copy link
Member

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8713 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8713 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #6318 completed with status: 'FAILURE'

@lucaslie
Copy link
Member

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8719 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8719 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6323 completed with status: 'FAILURE'

* Why?

`ruff check` and `ruff format` are standard linting and formatting tools
used in python projects. Prior to this commit, they were only enabled
for a very minor subset of the repo.

* What?

This commit is the first in a series to add more files in the include
list. The order is roughly from least to most frequently updated files /
directories.

It also removes the `isort` and `autoflake` hooks, since `ruff` covers
both of those.

Signed-off-by: William Zhang <[email protected]>
@lucaslie
Copy link
Member

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8854 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8854 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6441 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@kaiyux kaiyux merged commit dc52b67 into NVIDIA:main Jun 14, 2025
3 checks passed
@djns99
Copy link
Collaborator

djns99 commented Jun 16, 2025

@2ez4bz I am finding this pre commit check is running on files that are not checked in to git, in particular I am using the integrated internal cutlass build and it is running on the internal cutlass repo and failing. Is there any way we can make this filter a bit more targeted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants