Skip to content

Conversation

kaiyux
Copy link
Member

@kaiyux kaiyux commented Jun 16, 2025

PR title

Please write the PR title by following template:

[JIRA ticket link/nvbug link/github issue link][fix/feat/doc/infra/...] <summary of this PR>

For example, assume I have a PR hope to support a new feature about cache manager of Jira TRTLLM-1000 ticket, it would be like

[TRTLLM-1000][feat] Support a new feature about cache manager

Description

Please explain the issue and the solution in short.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@kaiyux kaiyux requested review from hypdeb and Funatiq June 16, 2025 06:56
@kaiyux
Copy link
Member Author

kaiyux commented Jun 16, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8989 [ run ] triggered by Bot

Copy link
Collaborator

@hypdeb hypdeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! It is concerning though that this went unnoticed until now.

Would you mind adding a unit test for this?

@kaiyux
Copy link
Member Author

kaiyux commented Jun 16, 2025

Good catch! It is concerning though that this went unnoticed until now.

Would you mind adding a unit test for this?

@hypdeb Can you help check if this commit does that? e7e70cd

@Funatiq
Copy link
Collaborator

Funatiq commented Jun 16, 2025

I think we should add a non-default client id here and here.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8989 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6563 completed with status: 'FAILURE'

@kaiyux kaiyux force-pushed the user/kaiyu/fix_deserialize_rsp branch from e7e70cd to c469cca Compare June 18, 2025 10:20
@kaiyux
Copy link
Member Author

kaiyux commented Jun 18, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9376 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9376 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6881 completed with status: 'FAILURE'

@kaiyux kaiyux force-pushed the user/kaiyu/fix_deserialize_rsp branch from 68ee000 to 177eecb Compare June 19, 2025 05:54
@kaiyux
Copy link
Member Author

kaiyux commented Jun 19, 2025

/bot run

@kaiyux kaiyux enabled auto-merge (squash) June 19, 2025 05:54
@tensorrt-cicd
Copy link
Collaborator

PR_Github #9454 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9454 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #6941 completed with status: 'FAILURE'

@kaiyux
Copy link
Member Author

kaiyux commented Jun 19, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9458 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9458 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #6943 completed with status: 'FAILURE'

kaiyux added 3 commits June 19, 2025 16:06
Signed-off-by: Kaiyu Xie <[email protected]>
Signed-off-by: Kaiyu Xie <[email protected]>
@kaiyux kaiyux force-pushed the user/kaiyu/fix_deserialize_rsp branch from 177eecb to 84be6dc Compare June 19, 2025 08:06
@kaiyux
Copy link
Member Author

kaiyux commented Jun 19, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9481 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9481 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6959 completed with status: 'FAILURE'

@kaiyux
Copy link
Member Author

kaiyux commented Jun 19, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9488 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9488 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6964 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@kaiyux kaiyux merged commit 113f6fb into NVIDIA:main Jun 19, 2025
3 checks passed
@kaiyux kaiyux deleted the user/kaiyu/fix_deserialize_rsp branch June 20, 2025 03:35
kaiyux added a commit to kaiyux/TensorRT-LLM that referenced this pull request Jun 20, 2025
kaiyux added a commit that referenced this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants