Skip to content

Conversation

chang-l
Copy link
Collaborator

@chang-l chang-l commented Jun 21, 2025

[TRTLLM-5195][feat] Share PyTorch tensor between processes

Description

This is a first PR split from #5000. It enables sharing of PyTorch tensors (both CPU and CUDA) across processes using shared memory and/or CUDA IPC, avoiding the overhead of serialization and inter-process communication.

Test Coverage

This PR includes tests covering both CPU and CUDA tensors, with various shapes and data types.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@chang-l chang-l marked this pull request as ready for review June 21, 2025 15:30
@chang-l chang-l requested a review from a team as a code owner June 21, 2025 15:30
@chang-l
Copy link
Collaborator Author

chang-l commented Jun 21, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9574 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9574 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #7032 completed with status: 'FAILURE'

@chang-l
Copy link
Collaborator Author

chang-l commented Jun 22, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9579 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #9579 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #7035 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

Copy link
Collaborator

@yechank-nvidia yechank-nvidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the wonderful work. LGTM. One general question below.

@pcastonguay pcastonguay requested a review from Superjomn June 25, 2025 18:10
@chang-l
Copy link
Collaborator Author

chang-l commented Jul 8, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11346 [ run ] triggered by Bot

@chang-l chang-l requested a review from dongxuy04 July 8, 2025 23:52
@tensorrt-cicd
Copy link
Collaborator

PR_Github #11346 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8397 completed with status: 'FAILURE'

@chang-l chang-l force-pushed the add_tensor_sharing branch from 103380b to e530120 Compare July 9, 2025 00:19
@chang-l
Copy link
Collaborator Author

chang-l commented Jul 9, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11357 [ run ] triggered by Bot

Copy link
Collaborator

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11357 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8405 completed with status: 'FAILURE'

@pcastonguay
Copy link
Collaborator

@chang-l could you check why CI is failing and/or retrigger the tests? Thanks

@chang-l chang-l force-pushed the add_tensor_sharing branch from a957839 to 3103e66 Compare July 9, 2025 17:22
@chang-l
Copy link
Collaborator Author

chang-l commented Jul 9, 2025

/bot run

@chang-l chang-l enabled auto-merge (squash) July 9, 2025 17:23
@tensorrt-cicd
Copy link
Collaborator

PR_Github #11460 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11460 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8479 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@chang-l chang-l merged commit b61a717 into NVIDIA:main Jul 9, 2025
3 checks passed
zhou-yuxin pushed a commit to zhou-yuxin/TensorRT-LLM that referenced this pull request Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants