Skip to content

Conversation

yuantailing
Copy link
Member

@yuantailing yuantailing commented Jul 8, 2025

Description

This is a hotfix for the problem introduced by #5534 , i.e., if the number of CUDA architecutes that ≥9.0 is an even number, the following error occurs:

-- deep_ep DEEP_EP_CUDA_ARCHITECTURES: 90-real;100-real
-- deep_ep DEEP_EP_URL: https://github.com/deepseek-ai/DeepEP/archive/c381dadf43a85062f6a8947592017ee513abc70b.tar.gz
CMake Error at tensorrt_llm/deep_ep/CMakeLists.txt:179 (set_target_properties):
  set_target_properties called with incorrect number of arguments.

The root cause is ${DEEP_EP_CUDA_ARCHITECTURES} is not quoted. The CI passed because there are 1 or 3 archs on CI.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@yuantailing
Copy link
Member Author

/bot run

@yuantailing yuantailing requested a review from kaiyux July 8, 2025 00:43
@yuantailing yuantailing changed the title Fix deep_ep cmake Fix a quote error introduced by #5534 Jul 8, 2025
@yuantailing
Copy link
Member Author

/bot run

1 similar comment
@yuantailing
Copy link
Member Author

/bot run

@yuantailing yuantailing changed the title Fix a quote error introduced by #5534 Fix a quote error introduced in #5534 Jul 8, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #11204 [ run ] triggered by Bot

@yuantailing
Copy link
Member Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11204 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8288 completed with status: 'FAILURE'

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11217 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11217 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8299 completed with status: 'FAILURE'

@yuantailing
Copy link
Member Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11230 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11230 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8307 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@yuantailing
Copy link
Member Author

/bot run --extra-stage "DGX_H100-4_GPUs-PyTorch-DeepSeek-1, DGX_H100-4_GPUs-PyTorch-DeepSeek-2"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11269 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #11269 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #8336 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@yuantailing yuantailing enabled auto-merge (squash) July 8, 2025 10:44
@yuantailing yuantailing merged commit ba0aea1 into NVIDIA:main Jul 8, 2025
3 checks passed
zhou-yuxin pushed a commit to zhou-yuxin/TensorRT-LLM that referenced this pull request Jul 15, 2025
@yuantailing yuantailing deleted the fix_deep_ep_cmake branch July 23, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants