Skip to content

infra: fix SBSA test stage #6113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2025
Merged

infra: fix SBSA test stage #6113

merged 2 commits into from
Jul 17, 2025

Conversation

ZhanruiSunCh
Copy link
Collaborator

@ZhanruiSunCh ZhanruiSunCh commented Jul 17, 2025 •
edited
Loading

Walkthrough

The Jenkins pipeline script was updated to add a new else branch in the "Test" stage to handle jobs that do not exclusively match single-GPU or multi-GPU patterns. This branch runs single-GPU tests in parallel first, then multi-GPU tests sequentially in a separate stage, complementing existing exclusive job handling.

Changes

File(s) Change Summary
jenkins/L0_Test.groovy Added an else branch in the "Test" stage to run single-GPU jobs in parallel followed by multi-GPU jobs sequentially, complementing existing exclusive single-GPU or multi-GPU job execution branches.

@ZhanruiSunCh
infra: fix SBSA test stage
0973ce0 
Signed-off-by: ZhanruiSunCh <[email protected]>
@ZhanruiSunCh ZhanruiSunCh requested a review from chzblych July 17, 2025 02:12
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 17, 2025 •
edited
Loading

Walkthrough

The Jenkins pipeline script was updated to add a new else branch in the "Test" stage to handle jobs that do not exclusively match single-GPU or multi-GPU patterns. This branch runs single-GPU tests in parallel first, then multi-GPU tests sequentially in a separate stage, complementing existing exclusive job handling.

Changes

File(s) Change Summary
jenkins/L0_Test.groovy Added an else branch in the "Test" stage to run single-GPU jobs in parallel followed by multi-GPU jobs sequentially, complementing existing exclusive single-GPU or multi-GPU job execution branches.

Poem

A hop in the pipeline, a leap in the flow,
Now single or multi, the script knows where to go.
With returns in the code, and logic so neat,
The tests run in order, no endless repeat.
🐇✨ The Jenkins bunny approves this feat!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0973ce0 and bfcaaf4.

📒 Files selected for processing (1)
  • jenkins/L0_Test.groovy (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • jenkins/L0_Test.groovy
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ZhanruiSunCh
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12137 [ run ] triggered by Bot

@ZhanruiSunCh
Fix
bfcaaf4 
Signed-off-by: ZhanruiSunCh <[email protected]>
@ZhanruiSunCh
Copy link
Collaborator Author

/bot run

@ZhanruiSunCh
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12140 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12137 [ run ] completed with state ABORTED

@ZhanruiSunCh
Copy link
Collaborator Author

/bot skip --comment "SBSA Test stage is start running as normal. Only infra change"

@ZhanruiSunCh ZhanruiSunCh self-assigned this Jul 17, 2025
@ZhanruiSunCh ZhanruiSunCh enabled auto-merge (squash) July 17, 2025 03:40
@tensorrt-cicd
Copy link
Collaborator

PR_Github #12150 [ skip ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12140 [ run ] completed with state ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #12150 [ skip ] completed with state SUCCESS
Skipping testing for commit bfcaaf4

@ZhanruiSunCh ZhanruiSunCh merged commit 4c364b9 into NVIDIA:main Jul 17, 2025
4 checks passed
yizhang-nv pushed a commit to yizhang-nv/TensorRT-LLM that referenced this pull request Jul 17, 2025
@ZhanruiSunCh @yizhang-nv
infra: fix SBSA test stage (NVIDIA#6113)
5d98b09 
Signed-off-by: ZhanruiSunCh <[email protected]>
@coderabbitai coderabbitai bot mentioned this pull request Jul 17, 2025
Merged
This was referenced Aug 20, 2025
Merged
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chzblych chzblych chzblych approved these changes

Assignees

@ZhanruiSunCh ZhanruiSunCh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZhanruiSunCh @tensorrt-cicd @chzblych