fix: Fix DeepSeek R1 CI #6129

yizhang-nv · 2025-07-17T06:08:25Z

PR title

Please write the PR title by following template:

[JIRA ticket link/nvbug link/github issue link][fix/feat/doc/infra/...] <summary of this PR>

For example, assume I have a PR hope to support a new feature about cache manager of Jira TRTLLM-1000 ticket, it would be like

[TRTLLM-1000][feat] Support a new feature about cache manager

Description

Please explain the issue and the solution in short.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Summary by CodeRabbit

Tests
- Adjusted GPU memory usage settings in multi-GPU tests for improved accuracy.
- Updated internal test checks to ensure correct backend verification.
- Removed skip entries for specific latency and throughput tests related to a known bug.

coderabbitai · 2025-07-17T06:08:31Z

Caution

Review failed

The pull request is closed.

Walkthrough

The test method test_nvfp4_multi_gpus in the TestDeepSeekR1 class was updated by adjusting the free_gpu_memory_fraction parameter from 0.85 to 0.80 for the key-value cache configuration and correcting the assertion to check the MOE backend via llm.args.moe_config.backend instead of llm.args.moe_backend. Additionally, two skip entries related to this test were removed from the waive list. No public interfaces were changed.

Changes

File(s)	Change Summary
tests/integration/defs/accuracy/test_llm_api_pytorch.py	Adjusted `free_gpu_memory_fraction` from 0.85 to 0.80 and fixed MOE backend assertion attribute
tests/integration/test_lists/waives.txt	Removed two skip entries for `test_nvfp4_multi_gpus` referencing bug `https://nvbugs/5397036`

Poem

In the warren of tests, a fraction did shift,
From eighty-five to eighty, a subtle, careful lift.
The backend path now rightly aligned,
No more assertion errors to find!
🐇 With every tweak and little fix,
Our code hops forward—swift and slick!

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8248a17 and 0db7aef.

📒 Files selected for processing (2)

tests/integration/defs/accuracy/test_llm_api_pytorch.py (2 hunks)
tests/integration/test_lists/waives.txt (0 hunks)

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

yizhang-nv · 2025-07-17T06:09:58Z

/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1,GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-2,GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-3,GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-4"

tensorrt-cicd · 2025-07-17T06:16:30Z

PR_Github #12161 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-17T08:53:35Z

PR_Github #12161 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #9032 (Partly Tested) completed with status: 'SUCCESS'

yizhang-nv · 2025-07-17T09:06:51Z

/bot skip --comment "All related tests are passed"

yizhang-nv · 2025-07-17T09:24:16Z

/bot skip --comment "All related tests are passed"

tensorrt-cicd · 2025-07-17T09:29:27Z

PR_Github #12190 [ skip ] triggered by Bot

tensorrt-cicd · 2025-07-17T09:42:54Z

PR_Github #12190 [ skip ] completed with state SUCCESS
Skipping testing for commit 4f79e81

yizhang-nv · 2025-07-17T10:19:10Z

/bot skip --comment "All related tests are passed"

Signed-off-by: Yi Zhang <[email protected]>

tensorrt-cicd · 2025-07-17T10:25:29Z

PR_Github #12197 [ ] completed with state FAILURE
Not allowed on merged PR

Signed-off-by: Yi Zhang <[email protected]>

yizhang-nv marked this pull request as ready for review July 17, 2025 09:06

yizhang-nv requested review from litaotju, chzblych and yiqingy0 July 17, 2025 09:06

chzblych approved these changes Jul 17, 2025

View reviewed changes

yiqingy0 approved these changes Jul 17, 2025

View reviewed changes

yizhang-nv requested review from a team as code owners July 17, 2025 09:19

yizhang-nv requested review from suyoggupta, nv-guomingz and lucaslie July 17, 2025 09:19

yizhang-nv force-pushed the improve-ci branch from c9cc167 to 4f79e81 Compare July 17, 2025 09:23

yizhang-nv removed request for a team, lucaslie, suyoggupta and nv-guomingz July 17, 2025 09:23

yizhang-nv enabled auto-merge (squash) July 17, 2025 09:24

litaotju approved these changes Jul 17, 2025

View reviewed changes

yizhang-nv force-pushed the improve-ci branch from 4f79e81 to 8248a17 Compare July 17, 2025 10:18

litaotju disabled auto-merge July 17, 2025 10:24

yizhang-nv added 2 commits July 17, 2025 18:24

fix CI

e0bf79d

Signed-off-by: Yi Zhang <[email protected]>

unwaive tests

0db7aef

Signed-off-by: Yi Zhang <[email protected]>

litaotju force-pushed the improve-ci branch from 8248a17 to 0db7aef Compare July 17, 2025 10:24

litaotju merged commit a718486 into NVIDIA:main Jul 17, 2025
2 checks passed

This was referenced Jul 17, 2025

test: Enable GB200 torch compile multi gpu tests #6145

Merged

[Infra] - Waive failed tests in post-merge #6176

Merged

test: [CI] remove closed bugs #6201

Merged

reasonsolo pushed a commit to reasonsolo/TensorRT-LLM that referenced this pull request Jul 21, 2025

fix: Fix DeepSeek R1 CI (NVIDIA#6129)

caf04b2

Signed-off-by: Yi Zhang <[email protected]>

coderabbitai bot mentioned this pull request Jul 24, 2025

Unwaive Granite LoRA test on L40S #6341

Closed

This was referenced Aug 1, 2025

[None][fix] update nemotron nas tests free_gpu_memory_fraction=0.8 #6552

Merged

[https://nvbugs/5436461][infra] Adjust free_gpu_memory_fraction of test_eagle3 to prevent OOM on CI #6631

Merged

coderabbitai bot mentioned this pull request Aug 11, 2025

[TRTLLM-6991][chore] add DeepSeek-R1 FP8 accuracy tests on Blackwell #6710

Merged

This was referenced Aug 18, 2025

[https://nvbugs/5448442][fix] Skip trtllm moe backend for sm120 #7010

Merged

[https://nvbugs/5455140][fix] unwaive DSR1-fp4 throughput_tp8 #7022

Merged

[TRTLLM-7363][test] Add 8-GPU test cases for RTX6000 #7083

Merged

This was referenced Aug 26, 2025

[None][chore] Update pre-merge test to add DeepSeek/LLaMA and gpt-oss #7192

Merged

[TRTLLM-7279][test] add accuracy test for deepseek-r1 with chunked_prefill #7365

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Fix DeepSeek R1 CI #6129

fix: Fix DeepSeek R1 CI #6129

Uh oh!

yizhang-nv commented Jul 17, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 17, 2025 •

edited

Loading

Review failed

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

yizhang-nv commented Jul 17, 2025

Uh oh!

tensorrt-cicd commented Jul 17, 2025

Uh oh!

tensorrt-cicd commented Jul 17, 2025

Uh oh!

yizhang-nv commented Jul 17, 2025

Uh oh!

yizhang-nv commented Jul 17, 2025

Uh oh!

tensorrt-cicd commented Jul 17, 2025

Uh oh!

tensorrt-cicd commented Jul 17, 2025

Uh oh!

yizhang-nv commented Jul 17, 2025

Uh oh!

Uh oh!

tensorrt-cicd commented Jul 17, 2025

Uh oh!

Uh oh!

fix: Fix DeepSeek R1 CI #6129

fix: Fix DeepSeek R1 CI #6129

Uh oh!

Conversation

yizhang-nv commented Jul 17, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR title

Description

Test Coverage

GitHub Bot Help

kill

skip

reuse-pipeline

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

yizhang-nv commented Jul 17, 2025

Uh oh!

tensorrt-cicd commented Jul 17, 2025

Uh oh!

tensorrt-cicd commented Jul 17, 2025

Uh oh!

yizhang-nv commented Jul 17, 2025

Uh oh!

yizhang-nv commented Jul 17, 2025

Uh oh!

tensorrt-cicd commented Jul 17, 2025

Uh oh!

tensorrt-cicd commented Jul 17, 2025

Uh oh!

yizhang-nv commented Jul 17, 2025

Uh oh!

Uh oh!

tensorrt-cicd commented Jul 17, 2025

Uh oh!

Uh oh!

yizhang-nv commented Jul 17, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 17, 2025 •

edited

Loading