[fix]: Revert commit 388b491 #6143
Conversation
WalkthroughThe changes remove PyTorch-backend-specific validation logic from the main LLM implementation and simplify related test code. Test helpers and test cases that handled PyTorch-specific branches are refactored or deleted, unifying error handling and reducing backend-specific code paths. Error messages are also streamlined for clarity. Changes
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (5)
💤 Files with no reviewable changes (1)
🔇 Additional comments (5)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
/bot run |
LinPoly
changed the title
|
PR_Github #12202 [ run ] triggered by Bot |
|
PR_Github #12202 [ run ] completed with state |
LinPoly
force-pushed
the
user/pengyunl/revert_check
branch
from
45b8d3c to
f5719de
Compare
|
/bot run |
|
PR_Github #12208 [ run ] triggered by Bot |
|
@coderabbitai summary |
✅ Actions performedSummary regeneration triggered. |
|
PR_Github #12208 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #12257 [ run ] triggered by Bot |
|
PR_Github #12257 [ run ] completed with state |
…al requests for pytorch backend (NVIDIA#5541)" This reverts commit 388b491. Signed-off-by: Pengyun Lin <[email protected]>
LinPoly
force-pushed
the
user/pengyunl/revert_check
branch
from
f5719de to
586fec2
Compare
|
/bot run --stage-list "H100_PCIe-PyTorch-3" |
|
PR_Github #12286 [ run ] triggered by Bot |
|
PR_Github #12286 [ run ] completed with state |
|
/bot skip --comment "pipeline passed after rerun" |
|
PR_Github #12306 [ skip ] triggered by Bot |
|
PR_Github #12306 [ skip ] completed with state |
Signed-off-by: Pengyun Lin <[email protected]>
Signed-off-by: Pengyun Lin <[email protected]>
Signed-off-by: Pengyun Lin <[email protected]>
Signed-off-by: Pengyun Lin <[email protected]>
Signed-off-by: Pengyun Lin <[email protected]>
This reverts commit 48ddc3d. Signed-off-by: Pengyun Lin <[email protected]>
This reverts commit 48ddc3d. Signed-off-by: Pengyun Lin <[email protected]>
Signed-off-by: Pengyun Lin <[email protected]> Signed-off-by: Shreyas Misra <[email protected]>
Signed-off-by: Pengyun Lin <[email protected]> Signed-off-by: Ransiki Zhang <[email protected]>
…al requests for pytorch backend (#5541)"
This reverts commit 388b491.
Summary by CodeRabbit
Bug Fixes
Tests
Description
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]Launch build/test pipelines. All previously running jobs will be killed.
--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-[Post-Merge]-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.md.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.