fix single_disagg_test #6166

chuangz0 · 2025-07-18T02:28:57Z

…ot_limit

Summary by CodeRabbit

Tests
- Updated a test to align its configuration and environment settings with other similar tests, ensuring consistency in test setups.

Description

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

coderabbitai · 2025-07-18T02:29:03Z

Walkthrough

The test test_disaggregated_spec_dec_batch_slot_limit in the integration suite was updated to include cache_transceiver_configs in its worker arguments and to use the "UCX_TLS": "^ib" environment variable for the MPI pool executor, aligning it with other similar tests in the file.

Changes

File(s)	Change Summary
tests/integration/defs/disaggregated/test_disaggregated_single_gpu.py	Modified a test to add `cache_transceiver_configs` to worker args and updated the MPI pool executor environment variable.

Suggested reviewers

pcastonguay
mikeiovine

Poem

In the warren of tests, a config hops in,
With transceivers aligned, the batch slots begin.
UCX whispers secrets, MPI takes a bow,
The single GPU smiles, all is in sync now.
🐇✨

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 920c219 and 94036b6.

📒 Files selected for processing (1)

tests/integration/defs/disaggregated/test_disaggregated_single_gpu.py (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

tests/integration/defs/disaggregated/test_disaggregated_single_gpu.py

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

chuangz0 · 2025-07-18T02:30:12Z

/bot run --stage-list "H100_PCIe-PyTorch-1"

…ot_limit Signed-off-by: Chuang Zhu <[email protected]>

tensorrt-cicd · 2025-07-18T02:36:15Z

PR_Github #12261 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-18T03:50:10Z

PR_Github #12261 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #9103 (Partly Tested) completed with status: 'SUCCESS'

chuangz0 · 2025-07-18T04:55:52Z

/bot skip --comment "the failed stage has passed"

tensorrt-cicd · 2025-07-18T05:00:51Z

PR_Github #12276 [ skip ] triggered by Bot

tensorrt-cicd · 2025-07-18T05:18:35Z

PR_Github #12276 [ skip ] completed with state SUCCESS
Skipping testing for commit 94036b6

Signed-off-by: Chuang Zhu <[email protected]>

Signed-off-by: Chuang Zhu <[email protected]> Signed-off-by: Shreyas Misra <[email protected]>

chuangz0 requested a review from Tabrizian July 18, 2025 02:28

add cache_transceiver_config for test_disaggregated_spec_dec_batch_sl…

94036b6

…ot_limit Signed-off-by: Chuang Zhu <[email protected]>

chuangz0 force-pushed the fix_disagg_spec_dec_batch_slot branch from 920c219 to 94036b6 Compare July 18, 2025 02:30

Tabrizian approved these changes Jul 18, 2025

View reviewed changes

chuangz0 requested a review from chzblych July 18, 2025 04:54

chuangz0 enabled auto-merge (squash) July 18, 2025 04:55

chzblych approved these changes Jul 18, 2025

View reviewed changes

chuangz0 merged commit c0e4165 into NVIDIA:main Jul 18, 2025
3 checks passed

reasonsolo pushed a commit to reasonsolo/TensorRT-LLM that referenced this pull request Jul 21, 2025

fix single_disagg_test (NVIDIA#6166)

d97a98e

Signed-off-by: Chuang Zhu <[email protected]>

timlee0212 pushed a commit to timlee0212/TensorRT-LLM that referenced this pull request Jul 21, 2025

fix single_disagg_test (NVIDIA#6166)

2e48a44

Signed-off-by: Chuang Zhu <[email protected]>

NVShreyas pushed a commit to NVShreyas/TensorRT-LLM that referenced this pull request Jul 28, 2025

fix single_disagg_test (NVIDIA#6166)

c421187

Signed-off-by: Chuang Zhu <[email protected]> Signed-off-by: Shreyas Misra <[email protected]>

coderabbitai bot mentioned this pull request Jul 30, 2025

[TRTLLM-7030][fix] BREAKING CHANGE: Mismatch between docs and actual commands #6323

Merged

This was referenced Aug 9, 2025

[TRTLLM-7030][fix] Refactor the example doc of dist-serving #6766

Merged

[TRTLLM-7030][fix] BREAKING CHANGE: Mismatch between docs and actual commands #6780

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix single_disagg_test #6166

fix single_disagg_test #6166

Uh oh!

chuangz0 commented Jul 18, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 18, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

chuangz0 commented Jul 18, 2025

Uh oh!

tensorrt-cicd commented Jul 18, 2025

Uh oh!

tensorrt-cicd commented Jul 18, 2025

Uh oh!

chuangz0 commented Jul 18, 2025

Uh oh!

tensorrt-cicd commented Jul 18, 2025

Uh oh!

tensorrt-cicd commented Jul 18, 2025

Uh oh!

Uh oh!

Uh oh!

fix single_disagg_test #6166

fix single_disagg_test #6166

Uh oh!

Conversation

chuangz0 commented Jul 18, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Description

Test Coverage

GitHub Bot Help

kill

skip

reuse-pipeline

Uh oh!

coderabbitai bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

chuangz0 commented Jul 18, 2025

Uh oh!

tensorrt-cicd commented Jul 18, 2025

Uh oh!

tensorrt-cicd commented Jul 18, 2025

Uh oh!

chuangz0 commented Jul 18, 2025

Uh oh!

tensorrt-cicd commented Jul 18, 2025

Uh oh!

tensorrt-cicd commented Jul 18, 2025

Uh oh!

Uh oh!

Uh oh!

chuangz0 commented Jul 18, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 18, 2025 •

edited

Loading