Skip to content

Conversation

xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Jul 28, 2025

waive failed cases.

Summary by CodeRabbit

  • Tests
    • Added two new test cases to the integration test skip list for BERT model configurations.
    • Applied a timeout limit to a LLAMA model test to ensure timely execution.

@xinhe-nv xinhe-nv requested review from crazydemo and LarryXFly July 28, 2025 19:26
Copy link
Contributor

coderabbitai bot commented Jul 28, 2025

📝 Walkthrough
## Walkthrough

Two new test cases from `examples/test_bert.py::test_llm_bert_general` were added to the skip list in `tests/integration/test_lists/waives.txt`, each linked to a specific bug. Additionally, a pytest timeout decorator of 7200 seconds was added to the test function `test_llm_llama_v3_1_1node_multi_gpus` in `tests/integration/defs/examples/test_llama.py`. No other changes were made.

## Changes

| Cohort / File(s)                                                                 | Change Summary                                                                                      |
|---------------------------------------------------------------------------------|---------------------------------------------------------------------------------------------------|
| **Test Waivers Update**<br>`tests/integration/test_lists/waives.txt`            | Added two new test cases to the skip list for BERT general tests with different model and dataset configurations, referencing bug `https://nvbugs/5421989`. |
| **Test Timeout Addition**<br>`tests/integration/defs/examples/test_llama.py`    | Added a `@pytest.mark.timeout(7200)` decorator to the test function `test_llm_llama_v3_1_1node_multi_gpus` to limit its execution time. |

## Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

## Possibly related PRs

- NVIDIA/TensorRT-LLM#6384: Adds new test cases to the same skip list file for waiving failing tests.
- NVIDIA/TensorRT-LLM#6331: Adds different sets of failing tests to the same waiver file.
- NVIDIA/TensorRT-LLM#6394: Adds new test cases to the skip list, managing test waivers in the same file.

## Suggested reviewers

- crazydemo
- yiqingy0
- LarryXFly

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 99676b9 and 7f91b80.

📒 Files selected for processing (2)
  • tests/integration/defs/examples/test_llama.py (1 hunks)
  • tests/integration/test_lists/waives.txt (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • tests/integration/test_lists/waives.txt
  • tests/integration/defs/examples/test_llama.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bca1415 and f18adf0.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: yiqingy0
PR: NVIDIA/TensorRT-LLM#5198
File: jenkins/mergeWaiveList.py:0-0
Timestamp: 2025-07-22T08:33:49.109Z
Learning: In the TensorRT-LLM waive list merging system, removed lines are always located at the end of the merge waive lists, which is why the mergeWaiveList.py script uses reverse traversal - it's an optimization for this specific domain constraint.
tests/integration/test_lists/waives.txt (2)

Learnt from: yiqingy0
PR: #5198
File: jenkins/mergeWaiveList.py:0-0
Timestamp: 2025-07-22T08:33:49.109Z
Learning: In the TensorRT-LLM waive list merging system, removed lines are always located at the end of the merge waive lists, which is why the mergeWaiveList.py script uses reverse traversal - it's an optimization for this specific domain constraint.

Learnt from: moraxu
PR: #6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.598Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check

@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250728_LLM_FUNCTION_TEST_1039 branch from f18adf0 to 99676b9 Compare July 29, 2025 06:24
@coderabbitai coderabbitai bot requested a review from yiqingy0 July 29, 2025 06:24
@xinhe-nv xinhe-nv changed the title Draft: test: [CI] Add failed cases into waives.txt test: [CI] Add failed cases into waives.txt Jul 29, 2025
@xinhe-nv xinhe-nv marked this pull request as ready for review July 29, 2025 06:25
@xinhe-nv xinhe-nv enabled auto-merge (squash) July 29, 2025 06:25
@xinhe-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #13313 [ run ] triggered by Bot

xinhe-nv added 2 commits July 29, 2025 01:42
Signed-off-by: xinhe-nv <[email protected]>
Signed-off-by: Xin He (SW-GPU) <[email protected]>
@xinhe-nv xinhe-nv force-pushed the user/qa/post_update_waive_20250728_LLM_FUNCTION_TEST_1039 branch from 99676b9 to 7f91b80 Compare July 29, 2025 08:42
@tensorrt-cicd
Copy link
Collaborator

PR_Github #13313 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #9947 completed with status: 'FAILURE'

@LarryXFly LarryXFly disabled auto-merge July 29, 2025 09:00
@LarryXFly LarryXFly merged commit 4fbb344 into NVIDIA:main Jul 29, 2025
2 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20250728_LLM_FUNCTION_TEST_1039 branch July 29, 2025 09:08
lancelly pushed a commit to lancelly/TensorRT-LLM that referenced this pull request Aug 6, 2025
Signed-off-by: xinhe-nv <[email protected]>
Signed-off-by: Xin He (SW-GPU) <[email protected]>
Signed-off-by: Lanyu Liao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants