Unwaive Gemma2 LoRA test on H100 #6461

brb-nv · 2025-07-29T22:14:42Z

Description

I'm not able to reproduce the timeout issues for nvbugs/5376087. So, unwaiving it.

Test Coverage

examples/test_gemma.py::test_hf_gemma_fp8_base_bf16_multi_lora[gemma-2-9b-it] ----> H100

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Summary by CodeRabbit

Tests
- Re-enabled a previously skipped test for the gemma-2-9b-it configuration.

coderabbitai · 2025-07-29T22:14:49Z

📝 Walkthrough

"""

Walkthrough

A single skip entry was removed from the test waiver list in tests/integration/test_lists/waives.txt, unskipping the test_hf_gemma_fp8_base_bf16_multi_lora[gemma-2-9b-it] test. No other changes were made to the file or to any other files.

Changes

Cohort / File(s)	Change Summary
Test Waiver Removal `tests/integration/test_lists/waives.txt`	Removed the skip entry for `test_hf_gemma_fp8_base_bf16_multi_lora[gemma-2-9b-it]`, unskipping this test.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

[test] Unwaive mistral3.1 small E2E test #6352: Removes a single test waiver entry in the same file to unskip a test.
test: [CI] remove closed bugs #6201: Removes skip entries for tests in the same file, un-waiving previously skipped tests.
[Infa] - waive failed cases and fix a typo #6384: Adds new skip entries and fixes typos in the same waiver file, related to test skip management.

Suggested reviewers

brb-nv
venkywonka
liji-nv
tburt-nv
"""

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f214c3e and 090298b.

📒 Files selected for processing (1)

tests/integration/test_lists/waives.txt (0 hunks)

💤 Files with no reviewable changes (1)

tests/integration/test_lists/waives.txt

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

brb-nv · 2025-07-29T22:16:02Z

/bot run --stage-list "H100_PCIe-TensorRT-1"

brb-nv · 2025-07-29T22:17:27Z

/bot run --stage-list "H100_PCIe-TensorRT-1"

tensorrt-cicd · 2025-07-29T22:22:44Z

PR_Github #13424 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-29T22:38:31Z

PR_Github #13423 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-29T22:38:33Z

PR_Github #13424 [ run ] completed with state ABORTED

brb-nv · 2025-07-29T22:47:48Z

/bot run --stage-list "H100_PCIe-TensorRT-1"

tensorrt-cicd · 2025-07-29T22:53:18Z

PR_Github #13431 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-29T22:53:21Z

PR_Github #13423 [ run ] completed with state ABORTED

brb-nv · 2025-07-29T23:33:30Z

/bot run --stage-list "H100_PCIe-TensorRT-1"

tensorrt-cicd · 2025-07-29T23:38:52Z

PR_Github #13434 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-29T23:38:54Z

PR_Github #13431 [ run ] completed with state ABORTED

brb-nv · 2025-07-30T00:40:56Z

/bot run --stage-list "H100_PCIe-TensorRT-1"

tensorrt-cicd · 2025-07-30T00:46:24Z

PR_Github #13441 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-30T00:46:26Z

PR_Github #13434 [ run ] completed with state ABORTED

brb-nv · 2025-07-30T01:42:37Z

/bot run --extra-stage "H100_PCIe-TensorRT-1" --disable-fail-fast

tensorrt-cicd · 2025-07-30T01:47:53Z

PR_Github #13454 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-30T01:47:55Z

PR_Github #13441 [ run ] completed with state ABORTED

brb-nv · 2025-07-30T06:18:46Z

/bot run --extra-stage "H100_PCIe-TensorRT-1" --disable-fail-fast

tensorrt-cicd · 2025-07-30T06:29:02Z

PR_Github #13494 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-30T06:29:05Z

PR_Github #13454 [ run ] completed with state ABORTED

tensorrt-cicd · 2025-07-30T09:58:00Z

PR_Github #13494 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #10106 completed with status: 'FAILURE'

brb-nv · 2025-07-30T14:58:23Z

/bot run

tensorrt-cicd · 2025-07-30T15:04:05Z

PR_Github #13551 [ run ] triggered by Bot

tensorrt-cicd · 2025-07-30T16:12:36Z

PR_Github #13551 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #10156 completed with status: 'SUCCESS'

Signed-off-by: Balaram Buddharaju <[email protected]>

amukkara · 2025-07-30T16:33:35Z

/bot reuse-pipeline

tensorrt-cicd · 2025-07-30T16:39:16Z

PR_Github #13560 [ reuse-pipeline ] triggered by Bot

tensorrt-cicd · 2025-07-30T16:56:10Z

PR_Github #13560 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #13551 for commit 090298b

Signed-off-by: Balaram Buddharaju <[email protected]> Signed-off-by: Lanyu Liao <[email protected]>

Signed-off-by: Balaram Buddharaju <[email protected]>

coderabbitai bot requested review from EmmaQiaoCh, liji-nv and venkywonka July 29, 2025 22:15

brb-nv force-pushed the user/brb/unwaive-tests-for-gemma2 branch from 675dbda to 44fcf86 Compare July 29, 2025 22:17

brb-nv force-pushed the user/brb/unwaive-tests-for-gemma2 branch from 44fcf86 to 9d17ad5 Compare July 30, 2025 06:16

amukkara enabled auto-merge (squash) July 30, 2025 16:16

amukkara force-pushed the user/brb/unwaive-tests-for-gemma2 branch from 9d17ad5 to f214c3e Compare July 30, 2025 16:17

amukkara self-requested a review July 30, 2025 16:17

amukkara approved these changes Jul 30, 2025

View reviewed changes

Unwaive Gemma2 LoRA test on H100

090298b

Signed-off-by: Balaram Buddharaju <[email protected]>

amukkara force-pushed the user/brb/unwaive-tests-for-gemma2 branch from f214c3e to 090298b Compare July 30, 2025 16:20

amukkara merged commit f6287e4 into NVIDIA:main Jul 30, 2025
3 checks passed

brb-nv deleted the user/brb/unwaive-tests-for-gemma2 branch July 31, 2025 00:48

lancelly pushed a commit to lancelly/TensorRT-LLM that referenced this pull request Aug 6, 2025

Unwaive Gemma2 LoRA test on H100 (NVIDIA#6461)

8b75766

Signed-off-by: Balaram Buddharaju <[email protected]> Signed-off-by: Lanyu Liao <[email protected]>

jain-ria pushed a commit to jain-ria/TensorRT-LLM that referenced this pull request Aug 7, 2025

Unwaive Gemma2 LoRA test on H100 (NVIDIA#6461)

6cb7dbe

Signed-off-by: Balaram Buddharaju <[email protected]>

This was referenced Aug 12, 2025

[https://nvbugs/5410399][chore] Unwaive mtp llmapi test #6833

Merged

[https://nvbugs/5375594][fix] fix oom issue on structural_tag test case #6838

Merged

Unwaive Gemma2 LoRA test on H100 #6461

Unwaive Gemma2 LoRA test on H100 #6461

Uh oh!

Conversation

brb-nv commented Jul 29, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Test Coverage

GitHub Bot Help

kill

skip

reuse-pipeline

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

brb-nv commented Jul 29, 2025

Uh oh!

brb-nv commented Jul 29, 2025

Uh oh!

tensorrt-cicd commented Jul 29, 2025

Uh oh!

tensorrt-cicd commented Jul 29, 2025

Uh oh!

tensorrt-cicd commented Jul 29, 2025

Uh oh!

brb-nv commented Jul 29, 2025

Uh oh!

tensorrt-cicd commented Jul 29, 2025

Uh oh!

tensorrt-cicd commented Jul 29, 2025

Uh oh!

brb-nv commented Jul 29, 2025

Uh oh!

tensorrt-cicd commented Jul 29, 2025

Uh oh!

tensorrt-cicd commented Jul 29, 2025

Uh oh!

brb-nv commented Jul 30, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

Uh oh!

brb-nv commented Jul 30, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

Uh oh!

brb-nv commented Jul 30, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

Uh oh!

brb-nv commented Jul 30, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

Uh oh!

amukkara commented Jul 30, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

Uh oh!

tensorrt-cicd commented Jul 30, 2025

brb-nv commented Jul 29, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 29, 2025 •

edited

Loading