Skip to content

Conversation

xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Aug 3, 2025

Remove closed bugs from waives.txt

Summary by CodeRabbit

  • Tests
    • Removed skip waivers for several tests, enabling them to run as part of the regular test suite.

@xinhe-nv xinhe-nv requested review from crazydemo and LarryXFly August 3, 2025 12:15
Copy link
Contributor

coderabbitai bot commented Aug 3, 2025

📝 Walkthrough

Walkthrough

This change removes several test skip entries from the tests/integration/test_lists/waives.txt waiver list. The affected entries correspond to specific multimodal and LLM API test cases that were previously skipped due to referenced NVIDIA bugs. No changes are made to test logic or code, only to the skip declarations.

Changes

Cohort / File(s) Change Summary
Waiver List Cleanup
tests/integration/test_lists/waives.txt
Removed skip entries for specific multimodal and LLM API test cases, unwaiving these tests.

Sequence Diagram(s)

No sequence diagram is generated, as the changes are limited to waiver list updates and do not affect code logic or control flow.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • test: [CI] remove closed bugs #6381: Both PRs modify the same test waiver file by removing skip entries related to NVIDIA bug IDs for similar multimodal and LLM API tests, indicating they are related updates to the test skip waiver list.
  • [test] Unwaive mistral3.1 small E2E test #6352: Both PRs modify the same file tests/integration/test_lists/waives.txt by removing skip entries for specific tests, indicating they are related in that they both unwaive previously skipped tests.
  • [nvbug/5409417] Unwaive llava test case #6460: Both PRs modify the same test waiver list file by removing skip entries for llava-related test cases, indicating they are related changes focused on unwaiving tests.

Suggested reviewers

  • crazydemo
  • yiqingy0
  • LarryXFly

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 94917ca and 4d39ac7.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt (0 hunks)
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@xinhe-nv xinhe-nv marked this pull request as ready for review August 4, 2025 01:35
@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20250803 branch from e72258f to 94bac0b Compare August 4, 2025 01:35
@xinhe-nv xinhe-nv enabled auto-merge (squash) August 4, 2025 01:36
@xinhe-nv xinhe-nv changed the title Draft: test: [CI] remove closed bugs [None][fix][CI] remove closed bugs Aug 4, 2025
@xinhe-nv
Copy link
Collaborator Author

xinhe-nv commented Aug 4, 2025

/bot run

@xinhe-nv xinhe-nv changed the title [None][fix][CI] remove closed bugs [None][fix] remove closed bugs Aug 4, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #13894 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #13894 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #10459 completed with status: 'FAILURE'

@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20250803 branch from 94bac0b to 94917ca Compare August 4, 2025 05:37
Signed-off-by: xinhe-nv <[email protected]>
@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20250803 branch from 94917ca to 4d39ac7 Compare August 4, 2025 05:50
@LarryXFly LarryXFly disabled auto-merge August 4, 2025 05:52
@LarryXFly LarryXFly merged commit a54972e into NVIDIA:main Aug 4, 2025
3 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/unwaive_20250803 branch August 4, 2025 06:06
lancelly pushed a commit to lancelly/TensorRT-LLM that referenced this pull request Aug 6, 2025
Signed-off-by: xinhe-nv <[email protected]>
Co-authored-by: Larry <[email protected]>
Signed-off-by: Lanyu Liao <[email protected]>
jain-ria pushed a commit to jain-ria/TensorRT-LLM that referenced this pull request Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants