[https://nvbugs/5444624][fix] Fix LLM_ROOT in triton_backend build.sh #6744
Conversation
Signed-off-by: Yiqing Yan <[email protected]>
📝 WalkthroughWalkthroughThe build script for the inflight batcher LLM backend was modified to calculate the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Note 🔌 MCP (Model Context Protocol) integration is now available in Early Access!Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
/bot run --stage-list "Build-Docker-Images" |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (2)
triton_backend/inflight_batcher_llm/scripts/build.sh (2)
38-38: Enable strict shell options to fail fastAdd -euo pipefail to catch errors early (undefined vars, command failures, pipeline errors). Keep -x for debug.
-set -x +set -euo pipefail +set -x
42-45: Make build dir creation idempotent and quote pathsUse mkdir -p to avoid failing on reruns if the directory exists, and quote variables to prevent word-splitting issues.
-BUILD_DIR=$(dirname $0)/../build -mkdir $BUILD_DIR -BUILD_DIR=$(cd -- "$BUILD_DIR" && pwd) -cd $BUILD_DIR +BUILD_DIR="$(dirname "$0")/../build" +mkdir -p "$BUILD_DIR" +BUILD_DIR="$(cd -- "$BUILD_DIR" && pwd)" +cd "$BUILD_DIR"
🧹 Nitpick comments (1)
triton_backend/inflight_batcher_llm/scripts/build.sh (1)
61-63: Optional: make copies idempotent and verboseNot required, but -f (overwrite) and -v (log) often help in CI to avoid stale-file errors and aid debugging.
-cp libtriton_tensorrtllm.so /opt/tritonserver/backends/tensorrtllm -cp trtllmExecutorWorker /opt/tritonserver/backends/tensorrtllm +cp -fv libtriton_tensorrtllm.so /opt/tritonserver/backends/tensorrtllm/ +cp -fv trtllmExecutorWorker /opt/tritonserver/backends/tensorrtllm/
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
triton_backend/inflight_batcher_llm/scripts/build.sh(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-08-06T13:58:07.506Z
Learnt from: galagam
PR: NVIDIA/TensorRT-LLM#6487
File: tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_bench.py:1-12
Timestamp: 2025-08-06T13:58:07.506Z
Learning: In TensorRT-LLM, test files (files under tests/ directories) do not require NVIDIA copyright headers, unlike production source code files. Test files typically start directly with imports, docstrings, or code.
Applied to files:
triton_backend/inflight_batcher_llm/scripts/build.sh
📚 Learning: 2025-08-01T15:14:45.673Z
Learnt from: yibinl-nvidia
PR: NVIDIA/TensorRT-LLM#6506
File: examples/models/core/mixtral/requirements.txt:3-3
Timestamp: 2025-08-01T15:14:45.673Z
Learning: In TensorRT-LLM, examples directory can have different dependency versions than the root requirements.txt file. Version conflicts between root and examples dependencies are acceptable because examples are designed to be standalone and self-contained.
Applied to files:
triton_backend/inflight_batcher_llm/scripts/build.sh
|
PR_Github #14586 [ run ] triggered by Bot |
|
PR_Github #14586 [ run ] completed with state |
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (2)
jenkins/scripts/get_triton_tag.sh (2)
7-7: Harden shell optionsUse stricter safety flags to avoid masked failures in pipelines.
-set -e +set -euo pipefail
28-37: Make ARG parsing resilient to whitespace, quotes, and inline commentsCurrent grep/cut misses cases like leading spaces, quoted values, or inline comments, and can propagate quotes into the tag. Suggest a more robust extraction:
Replace the parsing block with something along these lines:
# Extract last occurrence of ARG TRITON_BASE_TAG=..., ignoring comments and spaces; strip optional quotes TRITON_BASE_TAG=$( sed -nE 's/^[[:space:]]*ARG[[:space:]]+TRITON_BASE_TAG=//p' "$DOCKERFILE_MULTI_PATH" \ | sed -E 's/[[:space:]]*#.*$//' \ | sed -E 's/^"//; s/"$//' \ | tail -n1 ) if [[ -n "${TRITON_BASE_TAG:-}" ]]; then TRITON_SHORT_TAG="r${TRITON_BASE_TAG%-py3}" echo "Using triton tag from Dockerfile.multi: $TRITON_SHORT_TAG" >&2 fi
🧹 Nitpick comments (1)
jenkins/scripts/get_triton_tag.sh (1)
39-41: Clarify error message when path is emptyIf the fallback search fails, DOCKERFILE_MULTI_PATH is empty and this prints “not found at ” with no path. Either exit earlier (preferred in previous comment) or include the expected default path in the message.
For example:
echo "Dockerfile.multi not found (checked: ${LLM_ROOT}/docker/Dockerfile.multi)" >&2
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
jenkins/scripts/get_triton_tag.sh(1 hunks)triton_backend/inflight_batcher_llm/scripts/build.sh(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- triton_backend/inflight_batcher_llm/scripts/build.sh
yiqingy0
force-pushed
the
fix_get_triton_tag
branch
from
d1124b2 to
79e91be
Compare
|
/bot run |
|
PR_Github #14591 [ run ] triggered by Bot |
yiqingy0
changed the title
Signed-off-by: Yiqing Yan <[email protected]>
Signed-off-by: Yiqing Yan <[email protected]>
|
PR_Github #14591 [ run ] completed with state |
Signed-off-by: Yiqing Yan <[email protected]>
|
/bot run |
|
PR_Github #14607 [ run ] triggered by Bot |
|
PR_Github #14607 [ run ] completed with state |
Summary by CodeRabbit
Description
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.