-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[None][chore] Remove closed bugs #6969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughRemoved and added SKIP entries in the integration waives list; added extra @skip_post_blackwell decorators (duplicated) above two Gemma tests in test_gemma.py; no signature or functional test logic changes. Changes
Sequence Diagram(s)sequenceDiagram
participant TR as Test Runner
participant D as @skip_post_blackwell
participant T as Parametrized Test
TR->>T: Discover test (parametrized)
TR->>D: Evaluate decorator(s) for post-blackwell
alt any decorator indicates skip
D-->>TR: Return skip
TR->>T: Mark as skipped (no invocations)
else none indicate skip
TR->>T: Execute parameterized invocations
end
Note right of D: Two consecutive decorators present for some tests
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
c3d2174
to
1bcc157
Compare
/bot run |
PR_Github #15552 [ run ] triggered by Bot |
028a7c1
to
4ba2b30
Compare
PR_Github #15552 [ run ] completed with state |
Signed-off-by: xinhe-nv <[email protected]>
Signed-off-by: Xin He (SW-GPU) <[email protected]>
Signed-off-by: Xin He (SW-GPU) <[email protected]>
4ba2b30
to
879893d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)
315-318
: Validate Phi FP8+BF16 LoRA waivers
- ✅ The
test_phi_fp8_with_bf16_lora
function is defined intests/integration/defs/examples/test_phi.py
(line 382).- ✅ All four parametrizations (
Phi-3-mini-128k-instruct
,Phi-3-small-128k-instruct
,Phi-3.5-mini-instruct
,Phi-4-mini-instruct
) are present in that file.- ✅ No duplicate waiver entries were found in
tests/integration/test_lists/waives.txt
.⚠️ Confirm whether failures occur across all platforms or only on specific ones. If they’re limited (e.g. only on CUDA or ROCm), switch from a global skip to a platform-scoped prefix, e.g.
full:CUDA/examples/test_phi.py::test_phi_fp8_with_bf16_lora[...] SKIP (…)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
tests/integration/defs/examples/test_gemma.py
(1 hunks)tests/integration/test_lists/waives.txt
(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- tests/integration/defs/examples/test_gemma.py
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.
Applied to files:
tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
Remove closed bugs from waives.txt
Summary by CodeRabbit