Skip to content

Conversation

xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Aug 27, 2025

waive failed cases.

Summary by CodeRabbit

  • Tests

    • Temporarily skipped three unstable integration tests to maintain reliable test runs and reduce false failures. This improves CI stability and speeds up feedback while known issues are tracked.
  • Chores

    • Updated test waiver list to reflect current known issues, reducing noise in test reports and focusing attention on actionable failures. No user-facing changes or functionality impacts.

Copy link
Contributor

coderabbitai bot commented Aug 27, 2025

📝 Walkthrough

Walkthrough

Added three SKIP entries to tests/integration/test_lists/waives.txt to waive specific failing tests, each annotated with an nvbugs reference.

Changes

Cohort / File(s) Summary
Test waivers
tests/integration/test_lists/waives.txt
Added 3 SKIP entries for: accuracy/test_llm_api_pytorch.py::TestLlama4MaverickInstruct::test_fp8_eagle3[tp8-torch_compile=True] (nvbugs/5483615), accuracy/test_disaggregated_serving.py::TestQwen3_8B::test_nixl_backend (nvbugs/5448748), accuracy/test_disaggregated_serving.py::TestDeepSeekV3Lite::test_nixl_backend (nvbugs/5448748).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • crazydemo
  • yiqingy0
  • LarryXFly

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8b21613 and 7021112.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

Applied to files:

  • tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (2)
tests/integration/test_lists/waives.txt (2)

353-354: All NIXL backend waivers verified and no duplicates found

  • tests/integration/defs/accuracy/test_disaggregated_serving.py defines both
    • TestDeepSeekV3Lite → test_nixl_backend (lines 639–647)
    • TestQwen3_8B → test_nixl_backend (lines 778–786)
  • tests/integration/test_lists/waives.txt contains exactly one SKIP entry for each:
    • accuracy/test_disaggregated_serving.py::TestDeepSeekV3Lite::test_nixl_backend (line 354)
    • accuracy/test_disaggregated_serving.py::TestQwen3_8B::test_nixl_backend (line 353)
  • Both waivers reference the same NVBUG (https://nvbugs/5448748) as intended
  • No other occurrences or duplicates of these entries were found in waives.txt

These waivers are accurate and non-duplicative.


352-352: Confirm Llama4 Maverick FP8 eagle3 waiver scope

  • Located class TestLlama4MaverickInstruct in
    tests/integration/defs/accuracy/test_llm_api_pytorch.py at line 551
  • Located def test_fp8_eagle3 in the same file at line 658
  • Found waiver entry in
    tests/integration/test_lists/waives.txt at line 352
  • Waiver entry is unscoped (no full:<PLATFORM>/ prefix), so it applies repo-wide across all SKUs

The test identifier matches the implementation and the waiver correctly covers all platforms. Approved.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Signed-off-by: xinhe-nv <[email protected]>
@xinhe-nv xinhe-nv closed this Aug 27, 2025
@xinhe-nv xinhe-nv deleted the user/qa/post_update_waive_20250827_DEBUG_LLM_FUNCTION_TEST_1665 branch August 27, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant