[https://nvbugs/5470782][fix] Add specific test names for test_deepseek.py #7318
Conversation
📝 WalkthroughWalkthroughUpdated two integration test list YAMLs: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
|
/bot run --stage-list "DGX_H100-4_GPUs-PyTorch-DeepSeek-2" |
|
PR_Github #16748 [ run ] triggered by Bot |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tests/integration/test_lists/test-db/l0_dgx_h100.yml (1)
80-81: Consider adding explicit TIMEOUTs for streaming tests.If these runs are occasionally long on CI, mirror the existing pattern and set TIMEOUT (90) to avoid queue churn.
Apply if needed:
- - unittest/_torch/multi_gpu_modeling/test_deepseek.py::test_deepseek_streaming[tp1-bf16-trtllm-deepseekv3_lite] - - unittest/_torch/multi_gpu_modeling/test_deepseek.py::test_deepseek_streaming[tp4-bf16-trtllm-deepseekv3_lite] + - unittest/_torch/multi_gpu_modeling/test_deepseek.py::test_deepseek_streaming[tp1-bf16-trtllm-deepseekv3_lite] TIMEOUT (90) + - unittest/_torch/multi_gpu_modeling/test_deepseek.py::test_deepseek_streaming[tp4-bf16-trtllm-deepseekv3_lite] TIMEOUT (90)
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
tests/integration/test_lists/test-db/l0_dgx_h100.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.
Applied to files:
tests/integration/test_lists/test-db/l0_dgx_h100.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (2)
tests/integration/test_lists/test-db/l0_dgx_h100.yml (2)
80-81: No missing DeepSeek tests—explicit list covers all existing casesAfter inspecting
tests/unittest/_torch/multi_gpu_modeling/test_deepseek.py, there is only one DeepSeek test function:
test_deepseek_streaming(model_name, backend, quant, tp_size), parameterized overtp_sizevalues[1, 4], producing exactly the two cases listed in your YAML:
test_deepseek_streaming[tp1-bf16-trtllm-deepseekv3_lite]test_deepseek_streaming[tp4-bf16-trtllm-deepseekv3_lite]No other
test_deepseek_*functions exist in the codebase, so the explicit selectors inl0_dgx_h100.ymlfully cover all DeepSeek tests. You can safely ignore the wildcard-coverage concern.Likely an incorrect or invalid review comment.
80-81: Nodeids match parametrization decorators and are stable
- Verified that
test_deepseek_streamingis defined in
tests/unittest/_torch/multi_gpu_modeling/test_deepseek.py(around lines 20–26).- Confirmed the following
@pytest.mark.parametrizedecorators:
model_name: ids=[“deepseekv3_lite”]backend: ids=[“trtllm”]quant: default id “bf16”tp_size: ids=[“tp1”, “tp4”]- The YML nodeids
test_deepseek_streaming[tp1-bf16-trtllm-deepseekv3_lite]and
test_deepseek_streaming[tp4-bf16-trtllm-deepseekv3_lite]
align exactly with these decorators and will remain stable across refactors.
|
PR_Github #16748 [ run ] completed with state |
|
/bot run --stage-list "DGX_H100-4_GPUs-PyTorch-DeepSeek-2" |
|
PR_Github #16761 [ run ] triggered by Bot |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
tests/integration/test_lists/test-db/l0_dgx_b200.yml(2 hunks)tests/integration/test_lists/test-db/l0_dgx_h100.yml(2 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-08-26T09:49:04.956Z
Learnt from: pengbowang-nv
PR: NVIDIA/TensorRT-LLM#7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").
Applied to files:
tests/integration/test_lists/test-db/l0_dgx_b200.ymltests/integration/test_lists/test-db/l0_dgx_h100.yml
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.
Applied to files:
tests/integration/test_lists/test-db/l0_dgx_b200.ymltests/integration/test_lists/test-db/l0_dgx_h100.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (3)
tests/integration/test_lists/test-db/l0_dgx_b200.yml (2)
97-101: Verify TestGPTOSS test ID parity across stages
The pre_merge stage lists[tp4-trtllm],[ep4-cutlass],[ep4-triton],[dp4-trtllm], whereas the post_merge stage (lines 97–101) now lists[tp4-cutlass],[tp4-triton],[ep4-trtllm],[dp4-cutlass],[dp4-triton]. Confirm this change is intentional or realign the two stages.
44-47: No action needed: backend ids correctly lowercased
Parametrize ids are explicitly set to ["cutlass","trtllm","triton"], ensuring node IDs match.tests/integration/test_lists/test-db/l0_dgx_h100.yml (1)
155-160: Backend ids for TestGPTOSS are already lowercase and consistent with parametrization.
|
PR_Github #16761 [ run ] completed with state |
|
/bot run --stage-list "DGX_H100-4_GPUs-PyTorch-DeepSeek-1, DGX_H100-4_GPUs-PyTorch-DeepSeek-2" |
|
PR_Github #16897 [ run ] triggered by Bot |
|
PR_Github #16897 [ run ] completed with state |
SimengLiu-nv
changed the title
|
/bot run --reuse-test |
SimengLiu-nv
force-pushed
the
debug_ds_tests
branch
from
ac71be9 to
07211cb
Compare
|
/bot run --reuse-test |
|
PR_Github #17010 [ run ] triggered by Bot |
|
PR_Github #17010 [ run ] completed with state |
|
/bot run --stage-list "DGX_H100-4_GPUs-PyTorch-DeepSeek-1, DGX_H100-4_GPUs-PyTorch-DeepSeek-2" |
|
PR_Github #17253 [ run ] triggered by Bot |
|
PR_Github #17253 [ run ] completed with state |
Eaiser to track test names and bugs. Signed-off-by: Simeng Liu <[email protected]>
SimengLiu-nv
force-pushed
the
debug_ds_tests
branch
from
07211cb to
ed7b2f5
Compare
|
/bot run --reuse-test |
|
PR_Github #17293 [ run ] triggered by Bot |
|
PR_Github #17293 [ run ] completed with state |
Summary by CodeRabbit
Description
Easier to track test names and bugs.
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.