Skip to content

Conversation

EmmaQiaoCh
Copy link
Collaborator

@EmmaQiaoCh EmmaQiaoCh commented Aug 29, 2025

Summary by CodeRabbit

  • Tests
    • Temporarily disabled select unit and integration tests in the LLM and model API suites.
    • Added skip entries to the test waivers list to streamline CI runs.
    • No changes to test logic or coverage intent beyond skipping affected cases.
  • Impact
    • Improves CI stability and reduces noise during test runs.
    • No user-facing functionality changes; runtime behavior and APIs remain unaffected.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@EmmaQiaoCh
Copy link
Collaborator Author

/bot run --stage-list "A100X-TensorRT-Post-Merge-1, A100X-TensorRT-Post-Merge-4, A100X-TensorRT-Post-Merge-5"

@EmmaQiaoCh EmmaQiaoCh changed the title [None][infra] Waive failed cases for main branch [None][infra] Waive failed cases for main branch 0829 Aug 29, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #16975 [ run ] triggered by Bot

Copy link
Contributor

coderabbitai bot commented Aug 29, 2025

📝 Walkthrough

Walkthrough

Adds three SKIP entries to tests/integration/test_lists/waives.txt and applies unconditional pytest skip decorators to selected unit tests in llmapi executor and TRT model API/quantization modules. Some files also add a pytest import to enable decorators. No test logic or signatures changed.

Changes

Cohort / File(s) Change summary
Integration waivers
tests/integration/test_lists/waives.txt
Added 3 SKIP entries referencing nvbugs 5444687 and 5488580.
LLMAPI executor unit tests
tests/unittest/llmapi/test_executor.py
Added @pytest.mark.skip(reason="https://nvbugs/5488280") to test_generation_bs2 and test_sync_generation (unconditional skip), alongside existing skipif.
TRT model API unit tests
tests/unittest/trt/model_api/test_model_level_api.py
Imported pytest; added @pytest.mark.skip(reason="https://nvbugs/5488280") to test_save_load and test_async_io.
TRT model quantization unit tests
tests/unittest/trt/model_api/test_model_quantization.py
Imported pytest; added @pytest.mark.skip(reason="https://nvbugs/5488280") to test_int4_awq_quantization and test_fp8_quantization.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • chzblych
  • ZhanruiSunCh
  • yiqingy0

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbit or @coderabbitai title anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

♻️ Duplicate comments (3)
tests/unittest/llmapi/test_executor.py (1)

103-105: Same as above for this test

Verify the NVBUG ID consistency and consider pruning the redundant skipif.

tests/unittest/trt/model_api/test_model_quantization.py (1)

68-72: Same issue for this skipped test

Rely on the main fix above so the skip is effective.

tests/unittest/trt/model_api/test_model_level_api.py (1)

107-108: Same as above for this skipped test

Ensure the main change is applied so this skip is effective outside pytest.

🧹 Nitpick comments (1)
tests/unittest/llmapi/test_executor.py (1)

81-83: Remove redundant skipif
The unconditional @pytest.mark.skip(reason="https://nvbugs/5488280") already skips this test in all environments, so you can drop the @pytest.mark.skipif(WORLD_SIZE != 1, reason="Must run on single MPI rank"). The NVBUG ID 5488280 is consistent with other skips and requires no change.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 62459d5 and b7ffbb2.

📒 Files selected for processing (4)
  • tests/integration/test_lists/waives.txt (1 hunks)
  • tests/unittest/llmapi/test_executor.py (2 hunks)
  • tests/unittest/trt/model_api/test_model_level_api.py (3 hunks)
  • tests/unittest/trt/model_api/test_model_quantization.py (3 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{cpp,cc,cxx,cu,h,hpp,hh,hxx,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.{cpp,cc,cxx,cu,h,hpp,hh,hxx,cuh,py}: Use spaces only; no tabs; indent with 4 spaces
Prepend NVIDIA copyright header (current year) to all source files (.cpp, .h, .cu, .py, etc.)

Files:

  • tests/unittest/trt/model_api/test_model_quantization.py
  • tests/unittest/trt/model_api/test_model_level_api.py
  • tests/unittest/llmapi/test_executor.py
**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Python code must target Python 3.8+
Indent Python with 4 spaces; no tabs
Preserve module namespaces when importing: from package.subpackage import foo; then call foo.SomeClass() instead of importing the class directly
Python naming: files snake_case; classes PascalCase; functions/methods snake_case; locals snake_case (prefix k_ when starting with a number); globals UPPER_SNAKE_CASE with G_ prefix; constants UPPER_SNAKE_CASE
Avoid shadowing outer-scope variables; initialize all externally visible members in init
Prefer docstrings for interfaces used outside a file; limit comments to function-internal or file-local interfaces
Use Google-style docstrings for classes and functions; document attributes/variables inline so Sphinx can render them
Avoid reflection when simpler alternatives exist; prefer explicit parameters and return dicts over locals()/dynamic tricks
In try/except, catch the narrowest exceptions possible; keep try bodies minimal and use else for the main logic when doing duck-typing checks

Files:

  • tests/unittest/trt/model_api/test_model_quantization.py
  • tests/unittest/trt/model_api/test_model_level_api.py
  • tests/unittest/llmapi/test_executor.py
🧠 Learnings (1)
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

Applied to files:

  • tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (6)
tests/unittest/llmapi/test_executor.py (1)

1-1: Missing NVIDIA copyright header

Per coding guidelines, prepend the 2025 NVIDIA header to this file.

tests/integration/test_lists/waives.txt (1)

349-352: Validate waived test selectors and bug ID consistency

  • Confirm the path accuracy/test_llm_api_pytorch.py and the three test definitions (including their exact param values) exist and are spelled correctly in the codebase.
  • Verify whether the skip-reason ID for TestLlama3_1_8BInstruct::test_fp8_4gpus[…] should be 5488580 (as listed) or 5488280 (as used elsewhere).
    (Location: tests/integration/test_lists/waives.txt:349-351)
tests/unittest/trt/model_api/test_model_quantization.py (2)

3-3: Import of pytest is appropriate for decorators

No issues.


1-1: Missing NVIDIA copyright header

Add the 2025 NVIDIA header per guidelines.

tests/unittest/trt/model_api/test_model_level_api.py (2)

6-6: pytest import is correct for new decorators

No issues.


1-1: Missing NVIDIA copyright header

Prepend the 2025 NVIDIA header per guidelines.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #16975 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #12743 (Partly Tested) completed with status: 'FAILURE'

@EmmaQiaoCh
Copy link
Collaborator Author

/bot run --stage-list "A100X-TensorRT-Post-Merge-1, A100X-TensorRT-Post-Merge-4, A100X-TensorRT-Post-Merge-5"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #16983 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #16983 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #12751 (Partly Tested) completed with status: 'SUCCESS'

@EmmaQiaoCh
Copy link
Collaborator Author

/bot skip --comment "Waive tests on main"

@EmmaQiaoCh EmmaQiaoCh changed the title [None][infra] Waive failed cases for main branch 0829 [None][infra] Waive failed cases for main branch 08/29 Aug 29, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #16996 [ skip ] triggered by Bot

@EmmaQiaoCh EmmaQiaoCh changed the title [None][infra] Waive failed cases for main branch 08/29 [None][infra] Waive failed tests on main branch 08/29 Aug 29, 2025
@EmmaQiaoCh EmmaQiaoCh enabled auto-merge (squash) August 29, 2025 14:20
@tensorrt-cicd
Copy link
Collaborator

PR_Github #16996 [ skip ] completed with state SUCCESS
Skipping testing for commit 63b2e93

@EmmaQiaoCh EmmaQiaoCh merged commit 15ec2b8 into NVIDIA:main Aug 29, 2025
8 of 11 checks passed
chang-l pushed a commit to chang-l/TensorRT-LLM that referenced this pull request Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants