[None][fix] Update deployment guide and cherry-pick CI test fix from main #7623
Conversation
dongfengy
changed the title
📝 WalkthroughWalkthroughDocs update GPT-OSS deployment guide YAML examples (stream_interval to 20; add attention_dp_config for CUTLASS). Tests: add W4A16_MXFP4 entry to gsm8k reference. Refactor GSM8K evaluation in PyTorch accuracy tests by removing inline skips/config, using patches for MAX_OUTPUT_LEN and scores_filter. Remove related waivers. Changes
Sequence Diagram(s)Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (5)
docs/source/deployment-guide/quick-start-recipe-for-gpt-oss-on-trtllm.md (3)
222-222: Fix typo: “Chat Compeletions” → “Chat Completions”User-facing typo in a heading.
- TODO: Use Chat Compeletions API / Responses API as the example after the PR is merged. + TODO: Use Chat Completions API / Responses API as the example after the PR is merged.
224-226: Remove/replace the example JSON with chain-of-thought-like contentThe sample response embeds internal analysis text; this is misleading. Replace with a minimal, realistic Chat Completions response or remove until ready.
238-239: Broken Markdown link formattingSwap link text and URL.
- We use OpenAI's official evaluation tool to test the model's accuracy. For more information see [https://github.com/openai/gpt-oss/tree/main/gpt_oss/evals](gpt-oss-eval). + We use OpenAI's official evaluation tool to test the model's accuracy. For more information see [gpt-oss-eval](https://github.com/openai/gpt-oss/tree/main/gpt_oss/evals).tests/integration/defs/accuracy/test_llm_api_pytorch.py (2)
2967-2970: Align model_name with reference groupThe new reference for W4A16_MXFP4 was added under “GPT-OSS/MXFP4”. Using “GPT-OSS/BF16” here bypasses that entry.
- model_name = "GPT-OSS/BF16" + model_name = "GPT-OSS/MXFP4"
2958-2966: Usemoe_configinstead of invalidmoe_backendkwarg in LLM init
Replace the unsupportedmoe_backend="TRITON"withmoe_config=MoeConfig(backend="TRITON")to match the LLM constructor API.- llm = LLM(self.MODEL_PATH, - tensor_parallel_size=tp_size, - pipeline_parallel_size=pp_size, - moe_expert_parallel_size=ep_size, - kv_cache_config=self.kv_cache_config, - **pytorch_config, - enable_attention_dp=attention_dp, - moe_backend="TRITON") + llm = LLM(self.MODEL_PATH, + tensor_parallel_size=tp_size, + pipeline_parallel_size=pp_size, + moe_expert_parallel_size=ep_size, + kv_cache_config=self.kv_cache_config, + **pytorch_config, + enable_attention_dp=attention_dp, + moe_config=MoeConfig(backend="TRITON"))tests/integration/defs/accuracy/test_llm_api_pytorch.py lines 2958–2966
🧹 Nitpick comments (1)
tests/integration/defs/accuracy/test_llm_api_pytorch.py (1)
2874-2876: Optional: deduplicate GSM8K patches with an autouse fixtureMinor cleanup: create a class-scoped autouse fixture applying these two patches to reduce repetition.
Also applies to: 2913-2915, 2947-2949
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
docs/source/deployment-guide/quick-start-recipe-for-gpt-oss-on-trtllm.md(2 hunks)tests/integration/defs/accuracy/references/gsm8k.yaml(1 hunks)tests/integration/defs/accuracy/test_llm_api_pytorch.py(3 hunks)tests/integration/test_lists/waives.txt(0 hunks)
💤 Files with no reviewable changes (1)
- tests/integration/test_lists/waives.txt
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Use only spaces, no tabs; indent with 4 spaces.
Files:
tests/integration/defs/accuracy/test_llm_api_pytorch.py
**/*.py
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.
Files:
tests/integration/defs/accuracy/test_llm_api_pytorch.py
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).
Files:
tests/integration/defs/accuracy/test_llm_api_pytorch.py
🧬 Code graph analysis (1)
tests/integration/defs/accuracy/test_llm_api_pytorch.py (2)
tensorrt_llm/evaluate/lm_eval.py (1)
GSM8K(440-488)tests/integration/defs/accuracy/accuracy_core.py (1)
GSM8K(293-308)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (8)
tests/integration/defs/accuracy/references/gsm8k.yaml (1)
192-193: W4A16_MXFP4 entry added — LGTM; ensure tests consume itLooks correct and consistent with other MXFP4 entries. Verify the W4A16 test looks up the “GPT-OSS/MXFP4” group (see test_w4a16 comment).
docs/source/deployment-guide/quick-start-recipe-for-gpt-oss-on-trtllm.md (3)
75-75: Increase stream_interval to 20 — LGTMMatches guidance to reduce tokenization overhead.
92-97: Confirm attention_dp_config option names for this branchPlease verify these keys exist in 1.1.0rc2: attention_dp_config.enable_balance, batching_wait_iters, timeout_iters. Else align with the actual TorchLlmArgs fields (e.g., batch_wait_* at top-level).
46-46: Container tag may be outdated for this release branchDoc targets release/1.1.0rc2 but uses release:1.0.0rc6. Update to the intended image tag for this guide.
tests/integration/defs/accuracy/test_llm_api_pytorch.py (4)
2874-2876: Good: centralize GSM8K eval behavior via mocksPatching MAX_OUTPUT_LEN and scores_filter at test entry is clean and reverts on teardown.
2913-2915: Same here — LGTMConsistent with the 1-GPU case.
2947-2949: Same here — LGTMConsistent application for W4A16 test.
2945-2953: Confirm intended backend for W4A16You hard-require TRITON here. Is W4A16 expected to run only on TRITON for GPT‑OSS on this branch, or should TRTLLM/CUTLASS also be covered?
dongfengy
force-pushed
the
release/1.1.0rc2-doc-test
branch
from
779b790 to
0397042
Compare
|
/bot run |
Signed-off-by: Dongfeng Yu <[email protected]>
…A#7332) Signed-off-by: bhsueh <[email protected]> Signed-off-by: Dongfeng Yu <[email protected]>
Signed-off-by: Dongfeng Yu <[email protected]>
Signed-off-by: Dongfeng Yu <[email protected]>
dongfengy
force-pushed
the
release/1.1.0rc2-doc-test
branch
from
0397042 to
7d77324
Compare
|
/bot run |
|
PR_Github #18088 [ run ] triggered by Bot |
|
PR_Github #18089 [ run ] triggered by Bot |
|
PR_Github #18088 [ run ] completed with state |
|
PR_Github #18089 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #18105 [ run ] triggered by Bot |
|
PR_Github #18105 [ run ] completed with state |
4 participants
For 2 it's a long story.
GPT-OSS test setup breaks other test: https://nvbugspro.nvidia.com/bug/5453727
Then it's updated to use mocker https://github.com/NVIDIA/TensorRT-LLM/pull/7151/files
But the mocker change actually broke the test on CI. (At that point GPT-OSS was waived for a completely different reason https://nvbugspro.nvidia.com/bug/5481087 so the mocker change passed the CI)
So #7333 waived the tests again after discovering they eventually failed.
The 1.1.0rc2 branched out right at this time.
Later on main the issue fixed by: #7332 and tests re-enabled.
This PR cherry-picks the mocker new fix from main.
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.
Summary by CodeRabbit
Documentation
Tests