[None][ci] add DGX_H100-2_GPUs-PyTorch-Others-1 pipeline #7629
Conversation
Signed-off-by: junq <[email protected]>
|
/bot run --only-multi-gpu-test |
📝 WalkthroughWalkthroughAdds DGX H100 2- and 4-GPU PyTorch entries to the Jenkins L0 matrix and expands multi-GPU selection to include 2-GPU jobs. Introduces a 2-GPU gating block in the DGX H100 test list and narrows/simplifies the 4-GPU PyTorch test set, adjusting specific markers and pruning many tests. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Developer
participant Jenkins as Jenkins L0 Pipeline
participant Matrix as Test Matrix
participant DGX as DGX H100 Nodes
Dev->>Jenkins: Trigger pre/post-merge CI
Jenkins->>Matrix: Load L0 config
alt Multi-GPU selection
Matrix-->>Jenkins: Include 2-, 4-, 8-GPU job keys (updated)
end
par 2-GPU path
Jenkins->>DGX: Schedule dgx-h100-x2 jobs
DGX-->>Jenkins: Run 2-GPU PyTorch suite (new gate)
and 4-GPU path
Jenkins->>DGX: Schedule dgx-h100-x4 jobs
DGX-->>Jenkins: Run pruned 4-GPU PyTorch suite (gpu4 marker)
end
Jenkins-->>Dev: Report results
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks (2 passed, 1 warning)❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Flag potential breaking changes that are not documented:
1. Identify changes to public APIs/exports, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints (including removed/renamed items and changes to types, required params, return values, defaults, or behavior).
2. Ignore purely internal/private changes (e.g., code not exported from package entry points or marked internal).
3. Verify documentation exists: a "Breaking Change" section in the PR description and updates to CHANGELOG.md.Please share your feedback with us on this Discord post. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
PR_Github #18125 [ run ] triggered by Bot |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
jenkins/L0_Test.groovy (1)
2349-2352: 2‑GPU included in multi‑GPU filters — add a post‑merge 2‑GPU stage for parityWith ONLY_MULTI_GPU_TEST + IS_POST_MERGE=true, only keys containing "Post-Merge" are kept; there’s no 2‑GPU post‑merge stage, so nothing runs. Consider adding a 2‑GPU post‑merge entry to x86TestConfigs.
Apply near existing post‑merge entries:
+ "DGX_H100-2_GPUs-PyTorch-Post-Merge-1": ["dgx-h100-x2", "l0_dgx_h100", 1, 1, 2],tests/integration/test_lists/test-db/l0_dgx_h100.yml (1)
3-37: New 2‑GPU Ubuntu H100 PyTorch gate — align selection and envLooks good. Two small checks:
- Ensure the runtime reports linux_distribution_name matching "ubuntu*" (container/base image mismatch would filter this out).
- Optional: narrow the multi_gpu unittest selection to gpu2 to avoid accidental pickup of non‑2‑GPU parametrizations.
- - unittest/_torch/multi_gpu -m "not post_merge" TIMEOUT (90) + - unittest/_torch/multi_gpu -m "gpu2 and not post_merge" TIMEOUT (90)
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
jenkins/L0_Test.groovy(2 hunks)tests/integration/test_lists/test-db/l0_dgx_h100.yml(2 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-08-26T09:49:04.956Z
Learnt from: pengbowang-nv
PR: NVIDIA/TensorRT-LLM#7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").
Applied to files:
tests/integration/test_lists/test-db/l0_dgx_h100.yml
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.
Applied to files:
tests/integration/test_lists/test-db/l0_dgx_h100.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (2)
jenkins/L0_Test.groovy (1)
1966-1968: 2‑GPU DGX H100 PyTorch stage added — please verify label existsStage name and GPU count wiring look right. Confirm the cluster has a selectable GPU label/class for "dgx-h100-x2" in KubernetesManager.selectGPU and capacity to satisfy nvidia.com/gpu=2 on those nodes; otherwise this stage will never schedule.
tests/integration/test_lists/test-db/l0_dgx_h100.yml (1)
53-53: Scoped llm_multi_gpu_pytorch to gpu4 only — LGTMThis matches the 4‑GPU gate intent.
Signed-off-by: junq <[email protected]>
|
/bot run --stage-list "DGX_H100-2_GPUs-PyTorch-Others-1" |
|
PR_Github #18125 [ run ] completed with state |
|
PR_Github #18158 [ run ] triggered by Bot |
|
PR_Github #18158 [ run ] completed with state |
|
/bot skip --comment "DGX_H100-2_GPUs-PyTorch-Others-1 passed" |
|
PR_Github #18237 [ skip ] triggered by Bot |
|
PR_Github #18237 [ skip ] completed with state |
Signed-off-by: junq <[email protected]>
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.