[None][chore] Add failed cases into waives.txt

[xinhe-nv]

waive failed cases.

Summary by CodeRabbit

• Tests
  • Temporarily skips a failing end-to-end test scenario due to a known upstream issue, improving CI stability.
  • Reduces false negatives in automated test runs while the underlying problem is addressed.
  • No impact on user-facing functionality or public APIs.

[xinhe-nv]

/bot run --skip-test

[tensorrt-cicd]

PR_Github #18679 [ run ] triggered by Bot

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds a single SKIP entry to tests/integration/test_lists/waives.txt to waive test_e2e.py::test_ptp_scaffolding for the DeepSeek-R1-Distill-Qwen-7B model configuration, referencing nvbugs/5517260.

Changes

Cohort / File(s)	Summary
Test waivers tests/integration/test_lists/waives.txt	Added one SKIP entry: test_e2e.py::test_ptp_scaffolding[DeepSeek-R1-Distill-Qwen-7B-DeepSeek-R1/DeepSeek-R1-Distill-Qwen-7B] with bug reference https://nvbugs/5517260.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• [TRTLLM-7250][fix] Add failed cases into waives.txt #7342 — Also updates tests/integration/test_lists/waives.txt to add SKIP entries for failing integration tests.
• [None][chore] Add failed cases into waives.txt #7251 — Adds a broader set of SKIP entries in the same waives file for other failing tests.
• [None][chore] Add failed cases into waives.txt #6914 — Modifies the same waives file to skip different failing tests.

Suggested reviewers

• crazydemo
• LarryXFly

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The PR description "waive failed cases." is overly terse and does not follow the repository's required template; it omits the required "Description", "Test Coverage", and "PR Checklist" sections and fails to list which test(s) are being waived, the rationale, links to failing logs or NVBugs entries, and any follow-up actions or owners. Given the template expectations, the current description is insufficient for reviewers to assess impact, test coverage, or whether the waiver is temporary.	Please update the PR description to follow the repository template: provide a clear "Description" explaining why each test is waived and whether the waiver is temporary, a "Test Coverage" section listing the exact test case(s) and links to logs or NVBugs IDs, and complete the PR Checklist with owners and any required follow-ups so reviewers can verify and approve the change.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The PR title "[None][chore] Add failed cases into waives.txt" accurately and concisely describes the primary change (adding failed test cases to waives.txt) and follows the repository title format, so a reviewer can quickly understand the main intent. It is specific to the changeset shown in the raw summary and does not contain unnecessary noise.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 44d5ccf and 9aece3b.

📒 Files selected for processing (1)

• tests/integration/test_lists/waives.txt (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📚 Learning: 2025-08-29T14:07:45.863Z

Learnt from: EmmaQiaoCh
PR: NVIDIA/TensorRT-LLM#7370
File: tests/unittest/trt/model_api/test_model_quantization.py:24-27
Timestamp: 2025-08-29T14:07:45.863Z
Learning: In TensorRT-LLM's CI infrastructure, pytest skip markers (pytest.mark.skip) are properly honored even when test files have __main__ blocks that call test functions directly. The testing system correctly skips tests without requiring modifications to the __main__ block execution pattern.

Applied to files:

• tests/integration/test_lists/waives.txt

📚 Learning: 2025-07-28T17:06:08.621Z

Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

Applied to files:

• tests/integration/test_lists/waives.txt

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Pre-commit Check

🔇 Additional comments (1)

tests/integration/test_lists/waives.txt (1)

355-355: Manual verification required — automated checks failed (shell errors).

Run from the repo root and paste outputs:

• rg -nP '\bdef\s+test_ptp_scaffolding\b' -C2 || grep -nR "def test_ptp_scaffolding" .
• rg -nF 'DeepSeek-R1-Distill-Qwen-7B' tests || grep -nF 'DeepSeek-R1-Distill-Qwen-7B' tests || true
• grep -nF 'test_e2e.py::test_ptp_scaffolding[DeepSeek-R1-Distill-Qwen-7B-DeepSeek-R1/DeepSeek-R1-Distill-Qwen-7B] SKIP (https://nvbugs/5517260)' tests/integration/test_lists/waives.txt | wc -l

If the test is missing or the param string differs, update/remove the waiver to match the actual test node id/params. If the count != 1, remove duplicate entries or consolidate the waiver.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[tensorrt-cicd]

PR_Github #18679 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #14030 (Partly Tested) completed with status: 'SUCCESS'