[TRTLLM-8269][test] do not explicitly pass temperature=0 to select greedy sampling

[ixlmar]

Description

This is a follow-up to a comment on #7294. Apparently, the changes made to some tests in #7294 are no longer required and hence reverted here.

Test Coverage

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

[ixlmar]

/bot run --disable-multi-gpu-test --disable-fail-fast

[tensorrt-cicd]

PR_Github #19610 [ run ] triggered by Bot

[ixlmar]

/bot run --disable-multi-gpu-test --disable-fail-fast

[tensorrt-cicd]

PR_Github #19613 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #19610 [ run ] completed with state ABORTED
LLM/main/L0_MergeRequest_PR #14749 (Blue Ocean) completed with status: ABORTED

[ixlmar]

/bot kill

[tensorrt-cicd]

PR_Github #19617 [ kill ] triggered by Bot

[tensorrt-cicd]

PR_Github #19613 [ run ] completed with state ABORTED
LLM/main/L0_MergeRequest_PR #14752 (Blue Ocean) completed with status: ABORTED

[tensorrt-cicd]

PR_Github #19617 [ kill ] completed with state SUCCESS
Successfully killed previous jobs for commit 4dd01b7

[ixlmar]

/bot run --disable-multi-gpu-test --disable-fail-fast

[tensorrt-cicd]

PR_Github #19665 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #19665 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #14798 (Partly Tested) completed with status: 'FAILURE'

[ixlmar]

/bot run --disable-multi-gpu-test --disable-fail-fast

[tensorrt-cicd]

PR_Github #19822 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #19822 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #14914 (Partly Tested) completed with status: 'FAILURE'

[ixlmar]

/bot run --disable-multi-gpu-test --disable-fail-fast

[tensorrt-cicd]

PR_Github #19943 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #19943 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15015 (Partly Tested) completed with status: 'FAILURE'

[ixlmar]

/bot run --disable-multi-gpu-test --disable-fail-fast

[tensorrt-cicd]

PR_Github #19973 [ run ] triggered by Bot

[ixlmar]

/bot run --disable-multi-gpu-test --disable-fail-fast

[tensorrt-cicd]

PR_Github #19980 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #19973 [ run ] completed with state ABORTED
LLM/main/L0_MergeRequest_PR #15035 (Blue Ocean) completed with status: ABORTED

[tensorrt-cicd]

PR_Github #19980 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15043 (Partly Tested) completed with status: 'FAILURE'

[ixlmar]

/bot run --disable-multi-gpu-test --disable-fail-fast

[tensorrt-cicd]

PR_Github #20077 [ run ] triggered by Bot

[ixlmar]

/bot run --disable-multi-gpu-test --disable-fail-fast

[tensorrt-cicd]

PR_Github #20091 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #20077 [ run ] completed with state ABORTED
LLM/main/L0_MergeRequest_PR #15125 (Blue Ocean) completed with status: ABORTED

[tensorrt-cicd]

PR_Github #20091 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15137 (Partly Tested) completed with status: 'SUCCESS'

[ixlmar]

/bot run

[tensorrt-cicd]

PR_Github #20108 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #20108 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15151 completed with status: 'SUCCESS'

[coderabbitai]

📝 Walkthrough

Walkthrough

Removed explicit temperature=0 usage from sample generation and tests. Adjusted generate_samples in two evaluators: one drops the temperature key from sampling_args; the other now yields None instead of a dict containing temperature. Updated a unit test to stop passing temperature=0 and removed related comments.

Changes

Cohort / File(s)	Summary
Evaluator sampling arg adjustments tensorrt_llm/evaluate/json_mode_eval.py, tensorrt_llm/evaluate/mmlu.py	json_mode_eval: removed "temperature": 0 from sampling_args while keeping guided_decoding. mmlu: changed second yielded element from a temperature dict to None. No other logic changes.
Unit test update tests/unittest/llmapi/apps/_test_openai_misc.py	Removed temperature=0 from client.chat.completions.create in test_request_cancellation and deleted two related comment lines.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.
Description Check	⚠️ Warning	The pull request description provides a Description section and a PR Checklist but omits the required formatted title using the repository’s template and leaves the Test Coverage section empty, which does not fully satisfy the description template requirements.	Please add a PR title that follows the “[JIRA ticket/…][type] Summary” format or use the @coderabbitai summary shortcut, and populate the Test Coverage section with specific tests or test cases that validate the reverted changes.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title clearly follows the repository’s convention by including the JIRA ticket, the change type, and a concise summary of the primary change, namely removing the explicit temperature=0 argument to enforce greedy sampling. It accurately reflects the main change described in the code diffs without unnecessary detail or noise.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}