Skip to content

[PyTorch][Mcore] Fix illegal memory access issue while using Mcore async checkpoint with fp8 tensorwise recipe #1956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhongbozhu
Copy link
Collaborator

Description

Replace the tex.dequantize with a torch implementation fixes the issue for now. Need to root cause why tex.dequantize did not work for the async cp, but working for the sync cp.

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Change A
  • Change B

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@zhongbozhu zhongbozhu requested a review from timmoon10 July 16, 2025 22:37
@zhongbozhu zhongbozhu added the bug Something isn't working label Jul 16, 2025
Copy link
Collaborator

@timmoon10 timmoon10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should understand the root cause of why the FP8 dequantize is failing.

@zhongbozhu
Copy link
Collaborator Author

Update:

tex.dequantize not working for Mcore's async cp is likely because the kernel is launched in a spawned process instead of a forked process. Calling a torch implementation can get away with it since pytorch internally might handle this case well.

We can either merge this PR but it's likely that we will do the same thing for the dequantize kernel of mxfp8 recipe. Or we can root cause why the kernel launch doesn't work in the spawned process and fix this issue once for all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants