[PyTorch] Multi-tensor swizzle scaling factors for MXFP8 and fuse padding zeros #2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xin Yao <[email protected]>
Signed-off-by: Xin Yao <[email protected]>
Signed-off-by: Xin Yao <[email protected]>
Signed-off-by: Xin Yao <[email protected]>
Signed-off-by: Xin Yao <[email protected]>
|
/te-ci |
for more information, see https://pre-commit.ci
Signed-off-by: Xin Yao <[email protected]>
Signed-off-by: Xin Yao <[email protected]>
|
/te-ci |
|
My review is mainly focusing on the changes to TE/Common. LGTM! |
timmoon10
reviewed
Aug 6, 2025
Signed-off-by: Xin Yao <[email protected]>
|
/te-ci |
phu0ngng
approved these changes
Aug 6, 2025
timmoon10
approved these changes
Aug 6, 2025
nv-akorzh
pushed a commit
to nv-akorzh/TransformerEngine
that referenced
this pull request
Aug 6, 2025
…ding zeros (NVIDIA#2019) * for loop Signed-off-by: Xin Yao <[email protected]> * bulk alloc Signed-off-by: Xin Yao <[email protected]> * multi-tensor swizzle Signed-off-by: Xin Yao <[email protected]> * pad zeros in swizzle kernels Signed-off-by: Xin Yao <[email protected]> * unify single- and multi-tensor swizzle Signed-off-by: Xin Yao <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix empty tensor list Signed-off-by: Xin Yao <[email protected]> * fix bug for col swizzle Signed-off-by: Xin Yao <[email protected]> * check context & fix signifiers Signed-off-by: Xin Yao <[email protected]> --------- Signed-off-by: Xin Yao <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Anton Korzh <[email protected]>
nv-akorzh
pushed a commit
to nv-akorzh/TransformerEngine
that referenced
this pull request
Aug 7, 2025
…ding zeros (NVIDIA#2019) * for loop Signed-off-by: Xin Yao <[email protected]> * bulk alloc Signed-off-by: Xin Yao <[email protected]> * multi-tensor swizzle Signed-off-by: Xin Yao <[email protected]> * pad zeros in swizzle kernels Signed-off-by: Xin Yao <[email protected]> * unify single- and multi-tensor swizzle Signed-off-by: Xin Yao <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix empty tensor list Signed-off-by: Xin Yao <[email protected]> * fix bug for col swizzle Signed-off-by: Xin Yao <[email protected]> * check context & fix signifiers Signed-off-by: Xin Yao <[email protected]> --------- Signed-off-by: Xin Yao <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Anton Korzh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From Nsys profile with 8 experts, each mnk=(4096, 4096, 4096), we're seeing 1.4x speedup on host side and 1.7x speedup on the device side.
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: