[JAX] TE Gemm custom call clean up #2030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Phuong Nguyen <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Phuong Nguyen <[email protected]>
Signed-off-by: Phuong Nguyen <[email protected]>
Signed-off-by: Phuong Nguyen <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Phuong Nguyen <[email protected]>
Signed-off-by: Phuong Nguyen <[email protected]>
Signed-off-by: Phuong Nguyen <[email protected]>
|
/te-ci JAX L1 |
jberchtold-nvidia
previously approved these changes
Aug 5, 2025
Signed-off-by: Phuong Nguyen <[email protected]>
Signed-off-by: Phuong Nguyen <[email protected]>
|
/te-ci JAX L1 |
jberchtold-nvidia
previously approved these changes
Aug 6, 2025
Signed-off-by: Phuong Nguyen <[email protected]>
|
/te-ci JAX L1 |
Signed-off-by: Phuong Nguyen <[email protected]>
|
/te-ci JAX L1 |
Signed-off-by: Phuong Nguyen <[email protected]>
|
/te-ci JAX L1 |
pggPL
pushed a commit
to pggPL/TransformerEngine
that referenced
this pull request
Aug 25, 2025
* rm batch_dim, sequence_dim, sequence_parallel_output Signed-off-by: Phuong Nguyen <[email protected]> * rm lhs_quantized_colwise and rhs_quantized_colwise Signed-off-by: Phuong Nguyen <[email protected]> * rm unnecessary transpose_batch_sequence arg from some modules Signed-off-by: Phuong Nguyen <[email protected]> --------- Signed-off-by: Phuong Nguyen <[email protected]> Signed-off-by: Pawel Gadzinski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans unnecessary implementations for
batched_dim,sequence_dim,sequence_parallel_output, andrhs/lhs_quantized_colwisein the TE GEMM custom call.Verified that this change does not affect E2E perf.
Type of change
Checklist: