-
Notifications
You must be signed in to change notification settings - Fork 511
[PyTorch] ONNX export of FP8 Current Scaling #2068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
cdcae9e
Compute amax in normalization forward in current scaling in untuned k…
janekb04 5e8c645
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 531d8c2
fix
pggPL 7c41268
Merge branch 'pr-2061' into onnx_current_scaling
pggPL 2d33f1b
fix
pggPL 14a3719
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] eb37999
Merge branch 'main' into onnx_current_scaling
pggPL 754b340
fix
pggPL 0c34985
code drop
pggPL f182d72
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] bec8c09
Merge branch 'pr-2083' into onnx_current_scaling
pggPL 5bcb317
fix
pggPL bd2946c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] aeb560a
fix
pggPL f2884bc
apply tims suggestions
pggPL 4d7de1b
fix
pggPL File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't current scaling have better numerics than delayed scaling?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We compare fp8 from TE with fp8 from onnxruntime, not fp8 with high precision. Since onnxruntime will use fp8quantizer it is expected that (float8quantizer vs float8qunatizer) will be closed that (float8CurrentScalingQuantizer vs emulation of current scaling using float8qunatizer.