Skip to content

Conversation

epwalsh
Copy link

@epwalsh epwalsh commented Sep 8, 2025

Description

Fixes #2159.

Fixes an issue with the RNG state shape in the JAX fused ring attention implementation.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: epwalsh <[email protected]>
@ptrendx
Copy link
Member

ptrendx commented Sep 17, 2025

@phu0ngng Could you take a look?

@phu0ngng phu0ngng self-requested a review September 17, 2025 20:32
@phu0ngng phu0ngng marked this pull request as ready for review September 17, 2025 20:33
@phu0ngng
Copy link
Collaborator

/te-ci JAX L1

@phu0ngng
Copy link
Collaborator

LGTM. Pending CI.
Many thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error running JAX fused_attn with RING strategy
3 participants