Skip to content

Add Python bindings for nvJitLink #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Oct 25, 2024
Merged

Add Python bindings for nvJitLink #157

merged 37 commits into from
Oct 25, 2024

Conversation

ksimpson-work
Copy link
Contributor

@ksimpson-work ksimpson-work commented Oct 10, 2024 •
edited by leofang
Loading

Close #98.

@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Oct 10, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang leofang self-requested a review October 11, 2024 00:49
@leofang leofang added P0 High priority - Must do! feature New feature or request cuda.bindings Everything related to the cuda.bindings module labels Oct 11, 2024
@leofang leofang added this to the cuda.core beta 1 milestone Oct 11, 2024
@leofang leofang linked an issue Oct 11, 2024 that may be closed by this pull request
Add nvjitlink bindings #98
Closed
@leofang leofang changed the title naive approach to adding bindings Add Python bindings for nvJitLink Oct 15, 2024
leofang
leofang requested changes Oct 21, 2024
View reviewed changes
@ksimpson-work ksimpson-work force-pushed the ksimpson/add_nvJitLink_bindings branch from 979cd14 to cb6c5b4 Compare October 22, 2024 00:54
@leofang leofang marked this pull request as ready for review October 22, 2024 18:31
leofang
leofang previously approved these changes Oct 22, 2024
View reviewed changes
@leofang
Copy link
Member

leofang commented Oct 22, 2024

cc @vzhurba01 for vis (in case you have time to take a look)

leofang
leofang previously approved these changes Oct 23, 2024
View reviewed changes
vzhurba01
vzhurba01 reviewed Oct 23, 2024
View reviewed changes
leofang
leofang reviewed Oct 25, 2024
View reviewed changes
@leofang
Copy link
Member

leofang commented Oct 25, 2024

One note: The added bindings do not need to be backported to the cuda-11 branch, as nvJitLink does not exist until CUDA 12.

@leofang leofang merged commit f1bfaf0 into main Oct 25, 2024
@leofang leofang deleted the ksimpson/add_nvJitLink_bindings branch October 25, 2024 16:43
@leofang
Copy link
Member

leofang commented Oct 25, 2024

Thanks for working on this & congrats to your first PR merge, @ksimpson-work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzhurba01 vzhurba01 vzhurba01 left review comments

@leofang leofang leofang approved these changes

Assignees

@ksimpson-work ksimpson-work

Labels
cuda.bindings Everything related to the cuda.bindings module feature New feature or request P0 High priority - Must do!
Projects
None yet
Milestone
cuda.core beta 1
Development

Successfully merging this pull request may close these issues.

Add nvjitlink bindings
3 participants
@ksimpson-work @leofang @vzhurba01