Skip to content

Enable Cython tests for cuda.bindings #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 6, 2025
Merged

Enable Cython tests for cuda.bindings #323

merged 11 commits into from
Jan 6, 2025

Conversation

leofang
Copy link
Member

@leofang leofang commented Dec 26, 2024

No description provided.

@leofang leofang added P1 Medium priority - Should do CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module labels Dec 26, 2024
@leofang leofang added this to the cuda-python 12-next, 11-next milestone Dec 26, 2024
@leofang leofang self-assigned this Dec 26, 2024
@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Dec 26, 2024

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@leofang
Copy link
Member Author

leofang commented Dec 26, 2024

/ok to test

@leofang
Copy link
Member Author

leofang commented Dec 26, 2024

/ok to test

@leofang
Copy link
Member Author

leofang commented Dec 26, 2024

/ok to test

@leofang
Copy link
Member Author

leofang commented Dec 26, 2024

/ok to test

@leofang
Copy link
Member Author

leofang commented Dec 27, 2024

/ok to test

@leofang
Copy link
Member Author

leofang commented Dec 27, 2024

/ok to test

@leofang
Copy link
Member Author

leofang commented Dec 27, 2024

/ok to test

@leofang
Copy link
Member Author

leofang commented Dec 27, 2024

/ok to test

leofang
leofang commented Dec 30, 2024
View reviewed changes
.github/workflows/gh-build-and-test.yml Outdated
Comment on lines 275 to 277
env:
# we use self-hosted runners on which setup-python behaves weirdly...
AGENT_TOOLSDIRECTORY: "/opt/hostedtoolcache"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xref:

leofang
leofang commented Dec 30, 2024
View reviewed changes
.github/workflows/gh-build-and-test.yml Outdated
@@ -280,6 +283,13 @@ jobs:
host-platform: ${{ matrix.host-platform }}
cuda-version: ${{ matrix.cuda-version }}

- name: Install dependencies
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I don't want to install any build tools in the test pipeline, but it seems to be the easiest path...

@leofang leofang requested a review from vzhurba01 December 30, 2024 04:54
@leofang leofang marked this pull request as ready for review December 30, 2024 04:54
@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Dec 30, 2024

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@leofang
Copy link
Member Author

leofang commented Dec 30, 2024

/ok to test

@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jan 3, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang leofang requested a review from ksimpson-work January 3, 2025 03:11
@leofang
Copy link
Member Author

leofang commented Jan 3, 2025

/ok to test

@leofang leofang added the to-be-backported Trigger the bot to raise a backport PR upon merge label Jan 4, 2025
@leofang
Copy link
Member Author

leofang commented Jan 6, 2025

This is ready.

@leofang leofang merged commit 7ffb964 into NVIDIA:main Jan 6, 2025
46 of 48 checks passed
@leofang leofang deleted the enable_cython_test branch January 6, 2025 17:26
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025

Git push to origin failed for 11.8.x with exitcode 1

@leofang
Copy link
Member Author

leofang commented Jan 6, 2025

Git push to origin failed for 11.8.x with exitcode 1

The bot hit an error because this PR touches the workflow files in .github:

git push --set-upstream origin backport-323-to-11.8.x
To https://github.com/NVIDIA/cuda-python
 ! [remote rejected] backport-323-to-11.8.x -> backport-323-to-11.8.x (refusing to allow a GitHub App to create or update workflow `.github/workflows/build-and-test.yml` without `workflows` permission)
error: failed to push some refs to 'https://github.com/NVIDIA/cuda-python'

It turns out that the default GITHUB_TOKEN does not have permission for this... so any PRs that touch the workflow files will need to be manually backported (we could instead use a scoped PAT but I am hasitant to do this) 🙁

leofang added a commit to leofang/cuda-python that referenced this pull request Jan 6, 2025
@leofang
Enable Cython tests for cuda.bindings (NVIDIA#323)
a13d6be 
* enable Cython tests for cuda.bindings

* build Cython test modules

* Update gh-build-and-test.yml

* Install system gcc

* No sudo

* also set CUDA_HOME

* Try to find Python include

* nit: add a skip condition and comments

* simplify
This was referenced Jan 6, 2025
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksimpson-work ksimpson-work ksimpson-work approved these changes

@vzhurba01 vzhurba01 Awaiting requested review from vzhurba01

Assignees

@leofang leofang

Labels
CI/CD CI/CD infrastructure cuda.bindings Everything related to the cuda.bindings module P1 Medium priority - Should do to-be-backported Trigger the bot to raise a backport PR upon merge
Projects
None yet
Milestone
cuda-python 12.8.0 & 11.8.6
Development

Successfully merging this pull request may close these issues.
2 participants
@leofang @ksimpson-work