Skip to content

Documentation remove gpu dependency #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 1, 2025
Merged

Documentation remove gpu dependency #398

merged 8 commits into from
Feb 1, 2025

Conversation

ksimpson-work
Copy link
Contributor

@ksimpson-work ksimpson-work commented Jan 15, 2025 •
edited
Loading

close #326

mock the import of cuda so that non explicit imports (cuda.core.XXX) do not try to import and cause a gpu runner dependency

@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jan 15, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ksimpson-work
Copy link
Contributor Author

/ok to test

2 similar comments
@ksimpson-work
Copy link
Contributor Author

/ok to test

@ksimpson-work
Copy link
Contributor Author

/ok to test

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@ksimpson-work ksimpson-work self-assigned this Jan 16, 2025
@ksimpson-work ksimpson-work added cuda.core Everything related to the cuda.core module P1 Medium priority - Should do test Improvements or additions to tests labels Jan 16, 2025
@ksimpson-work ksimpson-work added this to the cuda.core beta 3 milestone Jan 16, 2025
@ksimpson-work ksimpson-work requested a review from leofang January 16, 2025 21:38
@ksimpson-work ksimpson-work marked this pull request as ready for review January 16, 2025 21:38
@ksimpson-work
Copy link
Contributor Author

/ok to test

@ksimpson-work
Copy link
Contributor Author

Preview looks good. merged main and removed the todo comments. Kicked a fresh CI for the requirements and sanity

leofang
leofang requested changes Jan 18, 2025
View reviewed changes
Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll need to hold off and fix both doc issues at once, see below.

@ksimpson-work ksimpson-work force-pushed the documentation-remove-gpu-dependency branch from da6310d to dfd383d Compare January 20, 2025 18:51
@ksimpson-work ksimpson-work requested a review from leofang January 22, 2025 17:04
@vzhurba01 vzhurba01 mentioned this pull request Jan 29, 2025
Merged
vzhurba01
vzhurba01 previously approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@vzhurba01 vzhurba01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After submission of this PR and PR #424 we can switch to a non-GPU machine runner.

@ksimpson-work ksimpson-work enabled auto-merge (squash) January 30, 2025 17:10
@ksimpson-work
Copy link
Contributor Author

/ok to test

@ksimpson-work
Copy link
Contributor Author

/ok to test

@ksimpson-work
Copy link
Contributor Author

@leofang I don't want to dismiss your review, but I have addressed your comments. Let me know if we're good to merge

@ksimpson-work
Merge remote-tracking branch 'origin/documentation-remove-gpu-depende…
914d179 
…ncy' into documentation-remove-gpu-dependency
@ksimpson-work
Copy link
Contributor Author

/ok to test

@leofang leofang disabled auto-merge February 1, 2025 05:12
@leofang leofang merged commit d6afedf into NVIDIA:main Feb 1, 2025
68 of 69 checks passed
@leofang
Copy link
Member

leofang commented Feb 1, 2025

Admin-merge because the only CI failure is due to network glitches that start showing up this week (?)

We should have another PR to switch the doc build runner to CPU

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2025

Doc Preview CI
Preview removed because the pull request was closed or merged.

@leofang leofang mentioned this pull request Feb 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzhurba01 vzhurba01 vzhurba01 left review comments

@leofang leofang Awaiting requested review from leofang

Assignees

@ksimpson-work ksimpson-work

Labels
cuda.core Everything related to the cuda.core module P1 Medium priority - Should do test Improvements or additions to tests
Projects
None yet
Milestone
cuda.core beta 3
Development

Successfully merging this pull request may close these issues.

Building cuda.core docs requires the presence of a physical GPU & valid driver
3 participants
@ksimpson-work @leofang @vzhurba01