Add nvvm bindings

[rwgk]

Closes #99

[copy-pr-bot]

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[rwgk]

/ok to test

[leofang]

I'll fix the CI failures. There are some changes needed in both the code and the CI.

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[leofang]

I think nvvm_windows.pyx is not quite right, but let's test Linux first

[rwgk]

/ok to test

[rwgk]

Tests are (very) complete now.

I only have one more TODO item for this PR: Try adding the 11.x headers.

[rwgk]

For completeness, this is how I determined that ERROR_INVALID_INPUT (4) is triggered by passing buffer NULL to nvvmAddModuleToProgram():

$ git diff

diff --git a/cuda_bindings/cuda/bindings/nvvm.pyx b/cuda_bindings/cuda/bindings/nvvm.pyx
index cf2a1d5..f747e81 100644
--- a/cuda_bindings/cuda/bindings/nvvm.pyx
+++ b/cuda_bindings/cuda/bindings/nvvm.pyx
@@ -153,6 +153,11 @@ cpdef add_module_to_program(intptr_t prog, buffer, size_t size, name):
         raise TypeError("name must be a Python str")
     cdef bytes _temp_name_ = (<str>name).encode()
     cdef char* _name_ = _temp_name_
+
+    cdef char* data_ptr = <char*> _buffer_.ptrs.data()
+    hex_representation = bytearray(<char[:size]> data_ptr).hex()
+    print(f"Buffer hex: {hex_representation}")
+
     with nogil:
         status = nvvmAddModuleToProgram(<Program>prog, <const char*>(_buffer_.ptrs.data()), size, <const char*>_name_)
     check_status(status)

$ pytest -s -v tests/test_nvvm.py

============================================================== test session starts ===============================================================
platform linux -- Python 3.12.8, pytest-8.3.4, pluggy-1.5.0 -- /home/rgrossekunst/forked/cuda-python/cuda_bindings/cbcv12_8Venv/bin/python
cachedir: .pytest_cache
benchmark: 5.1.0 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
rootdir: /home/rgrossekunst/forked/cuda-python/cuda_bindings/tests
configfile: pytest.ini
plugins: benchmark-5.1.0
collecting ... 
collected 9 items                                                                                                                                

tests/test_nvvm.py::test_nvvm_version PASSED
tests/test_nvvm.py::test_nvvm_ir_version PASSED
tests/test_nvvm.py::test_create_and_destroy PASSED
tests/test_nvvm.py::test_add_module_to_program FAILED
tests/test_nvvm.py::test_lazy_add_module_to_program PASSED
tests/test_nvvm.py::test_compile_program PASSED
tests/test_nvvm.py::test_verify_program PASSED
tests/test_nvvm.py::test_get_compiled_result PASSED
tests/test_nvvm.py::test_get_program_log PASSED

==================================================================== FAILURES ====================================================================
___________________________________________________________ test_add_module_to_program ___________________________________________________________

    def test_add_module_to_program():
        prog = nvvm.create_program()
        try:
            with pytest.raises(nvvm.nvvmError, match=r"^ERROR_INVALID_INPUT \(4\)$"):
>               nvvm.add_module_to_program(prog, [], 0, "SomeName")

tests/test_nvvm.py:35: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
cuda/bindings/nvvm.pyx:133: in cuda.bindings.nvvm.add_module_to_program
    cpdef add_module_to_program(intptr_t prog, buffer, size_t size, name):
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

>   hex_representation = bytearray(<char[:size]> data_ptr).hex()
E   ValueError: Cannot create cython.array from NULL pointer

cuda/bindings/nvvm.pyx:158: ValueError
============================================================ short test summary info =============================================================
FAILED tests/test_nvvm.py::test_add_module_to_program - ValueError: Cannot create cython.array from NULL pointer
========================================================== 1 failed, 8 passed in 0.02s ===========================================================

[rwgk]

@leofang I backtracked for the minute and added be55676 based on our discussion yesterday. That extra rpath

• helps if I pip install cuda-bindings into the conda env
• but does not help if cuda-bindings is pip-installed into a separate venv

What I had under b45bac2 (reverted at the moment) fixes that.

I want to enumerate the situations that we may encounter, to then 1. decide what we want to accommodate, and 2. find corresponding solutions.

[rwgk]

/ok to test

[leofang]

Looks great!

[github-actions]

Backport failed for 11.8.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 11.8.x
git worktree add -d .worktree/backport-421-to-11.8.x origin/11.8.x
cd .worktree/backport-421-to-11.8.x
git switch --create backport-421-to-11.8.x
git cherry-pick -x 2981bfd875a0576283fb54130d7b52f29071531c

[github-actions]

Doc Preview CI
Preview removed because the pull request was closed or merged.

[leofang]

@rwgk we forgot about adding docs, would you take care of it?